Skip to content

Conversation

@marcelpetrick
Copy link
Contributor

Non-functional changes only:

  • Fixed minor spelling mistakes in comments
  • Corrected typos in user-facing strings
  • No variables, logic, or functional code was modified.

Signed-off-by: Marcel Petrick mail@marcelpetrick.it

Non-functional changes only:
- Fixed minor spelling mistakes in comments
- Corrected typos in user-facing strings
- No variables, logic, or functional code was modified.

Signed-off-by: Marcel Petrick <mail@marcelpetrick.it>
@lurch
Copy link
Contributor

lurch commented Dec 3, 2025

The files in the dependencies directory come from 3rd-party projects, so it probably doesn't make sense to fix typos in those?
(Of course if you're feeling super-keen you're welcome to try and get those typos fixed in their upstream projects)

Signed-off-by: Marcel Petrick <mail@marcelpetrick.it>
@marcelpetrick
Copy link
Contributor Author

The files in the dependencies directory come from 3rd-party projects, so it probably doesn't make sense to fix typos in those? (Of course if you're feeling super-keen you're welcome to try and get those typos fixed in their upstream projects)

Thank you for pointing this out. You are right and I have reverted those two changes.
Changing code of dependencies just leads to confusion next time they are updated.

debian/changelog Outdated
* OS List: Fixed 'Recommended' tag annotation
* i18n: Added zh-TW Traditional Chinese translation
* i18n: Updated Korean, German, Ukranian, translations
* i18n: Updated Korean, German, Ukrainian, translations
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I appreciate the review - changing previous changelog entries is not something I generally countenance: it feels a little too much like trying to revise history, even if the history you're revising is careless typos.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tdewey-rpi I have reverted those changes for compliance.

(Personally, I have the view that the "current state" should be correct. Even if this means altering the past.)

Signed-off-by: Marcel Petrick <mail@marcelpetrick.it>
@lurch
Copy link
Contributor

lurch commented Dec 8, 2025

The os-list-schema.html file is autogenerated, so you should also fix https://github.com/raspberrypi/rpi-imager/blob/main/doc/json-schema/os-list-schema.json#L398 otherwise your correction will be lost the next time we regenerate os-list-schema.html 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants