RDKEMW-11471: Remove netType param #164
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason for change: Test Procedure: Risks: Signed-off-by: Kelvin Lu <Kelvin_Lu@comcast.com>
Reason for change: Test Procedure: Risks: Signed-off-by: Kelvin Lu <Kelvin_Lu@comcast.com>
klu339
force-pushed
the
feature/RDKEMW-11471
branch
from
88f4c8a to
0d3d303
Compare
There was a problem hiding this comment.
Pull request overview
This PR removes the netType parameter from various IPC calls and introduces network-specific controller ID ranges to support multi-network RCU management. The changes simplify the API by defaulting to all networks while adding infrastructure for proper ID range management across RF4CE and BLE networks.
Key changes:
- Removed
netTypeparameter from IPC functions (program_ir_codes, clear_ir_codes, get_net_status, get_last_keypress, find_my_remote, write_rcu_wakeup_config) - Introduced network ID range constants (
NETWORK_ID_BASE_*and corresponding*_RCU_ID_RANGE_MIN/MAXmacros) - Updated controller ID assignment logic to use network-specific ranges
- Refactored
get_net_statusto aggregate data from all networks and report network type information - Added BLE controller ID migration logic to handle legacy IDs outside the new range
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/rf4ce/ctrlm_rf4ce_network.h | Defines RF4CE controller ID range constants |
| src/rf4ce/ctrlm_rf4ce_network.cpp | Updates controller ID assignment to use RF4CE-specific range |
| src/irdb/ipc/ctrlm_irdb_ipc_iarm_thunder.cpp | Removes netType parameter handling from IR code programming functions |
| src/ipc/ctrlm_rcp_ipc_iarm_thunder.cpp | Removes netType parameter from multiple IPC functions and refactors get_net_status to aggregate network data |
| src/ipc/ctrlm_rcp_ipc_event.h | Adds new getter methods for network status data |
| src/ipc/ctrlm_rcp_ipc_event.cpp | Implements new getter methods for accessing network status fields |
| src/ctrlm_network.h | Moves network ID base constants from ctrlm_main.cpp to header for wider visibility |
| src/ctrlm_main.cpp | Removes network ID base constant definitions (moved to header) |
| src/ctrlm_controller.h | Adds controller_id_set method declaration |
| src/ctrlm_controller.cpp | Implements controller_id_set method |
| src/ble/ctrlm_ble_network.h | Defines BLE controller ID range constants |
| src/ble/ctrlm_ble_network.cpp | Updates controller ID assignment to use BLE-specific range and adds legacy ID migration logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
egalla204
reviewed
Dec 16, 2025
Reason for change: Test Procedure: Risks: Signed-off-by: Kelvin Lu <Kelvin_Lu@comcast.com>
dwolaver
reviewed
Dec 18, 2025
Contributor
dwolaver
reviewed
Dec 18, 2025
Contributor
dwolaver
left a comment
dwolaver
left a comment
There was a problem hiding this comment.
looks good for QA test!
egalla204
reviewed
Dec 18, 2025
Reason for change: Test Procedure: Risks: Signed-off-by: Kelvin Lu <Kelvin_Lu@comcast.com>
Contributor
Contributor
|
b'## WARNING: A Blackduck scan failure has been waived A prior failure has been upvoted
|
egalla204
reviewed
Jan 2, 2026
egalla204
reviewed
Jan 4, 2026
egalla204
reviewed
Jan 4, 2026
egalla204
reviewed
Jan 4, 2026
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.