Skip to content

Conversation

@SifAa
Copy link

@SifAa SifAa commented Dec 16, 2025

I discovered that when calling Manifest.serialize() it did not return correctly for sortAs in metadata and that undefined language did not use a correct BCP-47 tag. This PR should fix it.

@JayPanoz JayPanoz self-requested a review December 17, 2025 12:58
@JayPanoz
Copy link
Contributor

So funny story, I will have to check if there is any side-effect re. undefinedund cos’ of the following:

const test = { undefined: "unknown", en: "english", fr: "french" }
test["en"] // Returns "english"
test[undefined] // Note the lack of quotes. Returns "unknown"

So I’ll have to check pretty much all packages for this, to see whether things accidentally worked because undefined was used instead of und when we didn’t have a defined value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants