Organizations: allow uploading avatar #614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agjohnson
reviewed
Jun 19, 2025
readthedocsext/theme/templates/organizations/partials/header.html
Outdated
Show resolved
Hide resolved
readthedocsext/theme/templates/organizations/partials/organization_list.html
Show resolved
Hide resolved
readthedocsext/theme/templates/organizations/partials/organization_list.html
Outdated
Show resolved
Hide resolved
|
And just reviewed the underlying. The templates here need to support ImageField better, but that can be separate work. This will take working with the SUI crispy templates in this repo, they are a little hard to work with and fairly complicated. We can tune afterwards, but maybe lets make an issue to track |
agjohnson
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screencast.From.2025-06-17.12-56-08.mp4
Looks like the error message from file fields is duplicated, I think we are overriding how we render fields in the new theme somewhere...
Matches readthedocs/readthedocs.org#12254