Build: shrink preview comment #12391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement what we discussed in #12295. This is not perfect and it doesn't pretend to be, it's just one of the implementations after a few discussion iterations in the comments. The idea of this PR is to have something a little better than what we have to be able to merge and move forward with.
ericholscher
approved these changes
Aug 11, 2025
|
I updated the tests and enabled auto-merge. Hopefully we can deploy this tomorrow and continue iterating. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement what we discussed in
#12295. This is not perfect and it doesn't pretend to be, it's just one of the implementations after a few discussion iterations in the comments.
The idea of this PR is to have something a little better than what we have to be able to merge and move forward with.
Closes #12295