Skip to content

Conversation

jpsim
Copy link
Collaborator

@jpsim jpsim commented Oct 17, 2022

No description provided.

@jpsim jpsim marked this pull request as ready for review October 17, 2022 21:48
@SwiftLintBot
Copy link

SwiftLintBot commented Oct 17, 2022

743 Warnings
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/AerialView.swift:438:23: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/DownloadManager.swift:199:7: warning: Comment Spacing Violation: Prefer at least one space after slashes for comments. (comment_spacing)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/Tab Management/Tab.swift:64:31: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/Tab Management/Tab.swift:936:23: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Settings/SettingsLoadingView.swift:34:23: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Activities/Controller/ActivitiesViewController.swift:20:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Activities/Controller/ActivitiesViewController.swift:210:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Activities/Controller/ActivitiesViewController.swift:233:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Activities/Controller/ActivitiesViewController.swift:49:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Activities/Controller/ActivitiesViewController.swift:55:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Activities/Controller/ActivitiesViewController.swift:72:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Activities/Controller/ActivitiesViewController.swift:78:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Activities/Controller/ActivitiesViewController.swift:88:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Activities/Views/Cells/ActivityProjectStatusCell.swift:27:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Activities/Views/Cells/ActivityProjectStatusCell.swift:56:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Activities/Views/Cells/ActivitySurveyResponseCell.swift:13:17: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Activities/Views/Cells/ActivitySurveyResponseCell.swift:24:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Activities/Views/Cells/ActivitySurveyResponseCell.swift:40:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Activities/Views/Cells/ActivitySurveyResponseCell.swift:81:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Activities/Views/Cells/ActivityUpdateCell.swift:15:17: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Activities/Views/Cells/ActivityUpdateCell.swift:30:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Activities/Views/Cells/ActivityUpdateCell.swift:59:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Activities/Views/Cells/FindFriendsFacebookConnectCell.swift:21:17: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Activities/Views/Cells/FindFriendsFacebookConnectCell.swift:36:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Activities/Views/Cells/FindFriendsFacebookConnectCell.swift:76:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Activities/Views/Cells/FindFriendsHeaderCell.swift:19:17: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Activities/Views/Cells/FindFriendsHeaderCell.swift:39:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/AddNewCard/Controller/AddNewCardViewController.swift:19:17: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/BackerDashboardPages/Controller/BackerDashboardViewController.swift:171:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/BackerDashboardPages/Controller/BackerDashboardViewController.swift:38:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/BackerDashboardPages/Controller/BackerDashboardViewController.swift:84:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/BackerDashboardPages/Controller/BackerDashboardViewController.swift:90:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/BackerDashboardProjects/Controller/BackerDashboardProjectsViewController.swift:103:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/BackerDashboardProjects/Controller/BackerDashboardProjectsViewController.swift:18:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/BackerDashboardProjects/Controller/BackerDashboardProjectsViewController.swift:45:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/BackerDashboardProjects/Controller/BackerDashboardProjectsViewController.swift:51:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/BackerDashboardProjects/Controller/BackerDashboardProjectsViewController.swift:85:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/BackerDashboardProjects/Controller/BackerDashboardProjectsViewController.swift:92:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/BackerDashboardProjects/Datasource/BackerDashboardProjectsDataSource.swift:31:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/BackerDashboardProjects/Views/Cells/BackerDashboardEmptyStateCell.swift:100:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/BackerDashboardProjects/Views/Cells/BackerDashboardProjectCell.swift:27:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/BackerDashboardProjects/Views/Cells/BackerDashboardProjectCell.swift:46:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/BetaTools/Views/BetaToolsFooterView.swift:21:17: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Comments/Controllers/CommentDialogViewController.swift:15:17: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Comments/Controllers/CommentDialogViewController.swift:25:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Comments/Controllers/CommentDialogViewController.swift:30:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Comments/Controllers/CommentDialogViewController.swift:47:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Comments/Controllers/CommentDialogViewController.swift:69:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Comments/Controllers/CommentRepliesViewController.swift:48:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Comments/Controllers/CommentRepliesViewController.swift:70:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Comments/Controllers/CommentRepliesViewController.swift:90:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Comments/Controllers/CommentsViewController.swift:100:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Comments/Controllers/CommentsViewController.swift:110:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Comments/Controllers/CommentsViewController.swift:58:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Comments/Controllers/CommentsViewController.swift:79:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Comments/Datasource/CommentRepliesDataSource.swift:59:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Comments/Datasource/CommentsDataSource.swift:63:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Comments/Views/Cells/CommentCell.swift:122:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Comments/Views/Cells/CommentPostFailedCell.swift:79:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Comments/Views/Cells/CommentRemovedCell.swift:109:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Comments/Views/Cells/RootCommentCell.swift:96:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Dashboard/Controller/DashboardViewController.swift:191:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Dashboard/Controller/DashboardViewController.swift:208:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Dashboard/Controller/DashboardViewController.swift:25:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Dashboard/Controller/DashboardViewController.swift:66:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Dashboard/Controller/UpdateDraftViewController.swift:15:17: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Dashboard/Controller/UpdateDraftViewController.swift:163:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Dashboard/Controller/UpdateDraftViewController.swift:191:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Dashboard/Controller/UpdateDraftViewController.swift:38:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Dashboard/Controller/UpdateDraftViewController.swift:61:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Dashboard/Controller/UpdatePreviewViewController.swift:18:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Dashboard/Controller/UpdatePreviewViewController.swift:27:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Dashboard/Controller/UpdatePreviewViewController.swift:34:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Dashboard/Datasource/DashboardDataSource.swift:58:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Dashboard/Views/Cells/DashboardActionCell.swift:19:17: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Dashboard/Views/Cells/DashboardActionCell.swift:32:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Dashboard/Views/Cells/DashboardActionCell.swift:46:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Dashboard/Views/Cells/DashboardActionCell.swift:58:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Dashboard/Views/Cells/DashboardContextCell.swift:13:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Dashboard/Views/Cells/DashboardFundingCell.swift:31:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Dashboard/Views/Cells/DashboardFundingCell.swift:77:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Dashboard/Views/Cells/DashboardReferrersCell.swift:13:17: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Dashboard/Views/Cells/DashboardReferrersCell.swift:154:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Dashboard/Views/Cells/DashboardReferrersCell.swift:42:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Dashboard/Views/Cells/DashboardReferrersCell.swift:72:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Dashboard/Views/Cells/DashboardRewardsCell.swift:23:17: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Dashboard/Views/Cells/DashboardRewardsCell.swift:25:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Dashboard/Views/Cells/DashboardRewardsCell.swift:53:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Dashboard/Views/Cells/DashboardRewardsCell.swift:85:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Dashboard/Views/Cells/DashboardVideoCell.swift:28:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Dashboard/Views/Cells/DashboardVideoCell.swift:89:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Dashboard/Views/DashboardTitleView.swift:19:17: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/DashboardProjects/Controller/DashboardProjectsDrawerViewController.swift:19:17: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/DashboardProjects/Controller/DashboardProjectsDrawerViewController.swift:31:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/DashboardProjects/Controller/DashboardProjectsDrawerViewController.swift:45:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/DashboardProjects/Controller/DashboardProjectsDrawerViewController.swift:95:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/DashboardProjects/Datasource/DashboardProjectsDrawerDataSource.swift:15:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/DashboardProjects/Views/Cells/DashboardProjectsDrawerCell.swift:22:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/DashboardProjects/Views/Cells/DashboardProjectsDrawerCell.swift:33:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/DebugPushNotifications/Controller/DebugPushNotificationsViewController.swift:18:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Discovery/Controller/DiscoveryNavigationHeaderViewController.swift:175:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Discovery/Controller/DiscoveryNavigationHeaderViewController.swift:37:17: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Discovery/Controller/DiscoveryNavigationHeaderViewController.swift:71:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Discovery/Controller/DiscoveryPageViewController.swift:104:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Discovery/Controller/DiscoveryPageViewController.swift:110:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Discovery/Controller/DiscoveryPageViewController.swift:116:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Discovery/Controller/DiscoveryPageViewController.swift:128:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Discovery/Controller/DiscoveryPageViewController.swift:142:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Discovery/Controller/DiscoveryPageViewController.swift:294:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Discovery/Controller/DiscoveryPageViewController.swift:322:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Discovery/Controller/DiscoveryPageViewController.swift:35:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Discovery/Views/Cells/ActivitySampleBackingCell.swift:13:17: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Discovery/Views/Cells/ActivitySampleBackingCell.swift:23:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/Discovery/Views/Cells/ActivitySampleBackingCell.swift:33:21: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
⚠️ Danger found 743 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 114.
39 Messages
📖 Linting Aerial with this PR took 1.45s vs 1.45s on main (0% slower)
📖 Linting Alamofire with this PR took 2.05s vs 2.04s on main (0% slower)
📖 Linting DuckDuckGo with this PR took 4.11s vs 4.05s on main (1% slower)
📖 Linting Firefox with this PR took 9.23s vs 9.0s on main (2% slower)
📖 Linting Kickstarter with this PR took 14.47s vs 15.42s on main (6% faster)
📖 Linting Moya with this PR took 0.99s vs 0.98s on main (1% slower)
📖 Linting Nimble with this PR took 0.85s vs 0.84s on main (1% slower)
📖 Linting Quick with this PR took 0.28s vs 0.28s on main (0% slower)
📖 Linting Realm with this PR took 16.49s vs 16.51s on main (0% faster)
📖 Linting SourceKitten with this PR took 0.58s vs 0.57s on main (1% slower)
📖 Linting Sourcery with this PR took 3.74s vs 3.69s on main (1% slower)
📖 Linting Swift with this PR took 6.4s vs 6.37s on main (0% slower)
📖 Linting WordPress with this PR took 14.5s vs 14.58s on main (0% faster)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncStream.swift:472:5: warning: Variable Declaration Whitespace Violation: Let and var should be separated from other statements by a blank line. (let_var_whitespace)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncThrowingStream.swift:517:5: warning: Variable Declaration Whitespace Violation: Let and var should be separated from other statements by a blank line. (let_var_whitespace)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/SuspendingClock.swift:114:3: warning: Variable Declaration Whitespace Violation: Let and var should be separated from other statements by a blank line. (let_var_whitespace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Availability.swift:104:3: warning: Variable Declaration Whitespace Violation: Let and var should be separated from other statements by a blank line. (let_var_whitespace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Availability.swift:98:3: warning: Variable Declaration Whitespace Violation: Let and var should be separated from other statements by a blank line. (let_var_whitespace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift:5541:3: warning: Variable Declaration Whitespace Violation: Let and var should be separated from other statements by a blank line. (let_var_whitespace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift:5550:3: warning: Variable Declaration Whitespace Violation: Let and var should be separated from other statements by a blank line. (let_var_whitespace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift:5562:3: warning: Variable Declaration Whitespace Violation: Let and var should be separated from other statements by a blank line. (let_var_whitespace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift:5578:3: warning: Variable Declaration Whitespace Violation: Let and var should be separated from other statements by a blank line. (let_var_whitespace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Codable.swift:5594:3: warning: Variable Declaration Whitespace Violation: Let and var should be separated from other statements by a blank line. (let_var_whitespace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Duration.swift:241:3: warning: Variable Declaration Whitespace Violation: Let and var should be separated from other statements by a blank line. (let_var_whitespace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Duration.swift:315:3: warning: Variable Declaration Whitespace Violation: Let and var should be separated from other statements by a blank line. (let_var_whitespace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/KeyPath.swift:3756:3: warning: Variable Declaration Whitespace Violation: Let and var should be separated from other statements by a blank line. (let_var_whitespace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/KeyPath.swift:3830:3: warning: Variable Declaration Whitespace Violation: Let and var should be separated from other statements by a blank line. (let_var_whitespace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/OptionSet.swift:147:10: warning: Redundant Type Annotation Violation: Variables should not have redundant type annotation (redundant_type_annotation)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Policy.swift:40:3: warning: Variable Declaration Whitespace Violation: Let and var should be separated from other statements by a blank line. (let_var_whitespace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/UnicodeSPI.swift:116:3: warning: Variable Declaration Whitespace Violation: Let and var should be separated from other statements by a blank line. (let_var_whitespace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/UnicodeSPI.swift:124:3: warning: Variable Declaration Whitespace Violation: Let and var should be separated from other statements by a blank line. (let_var_whitespace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/UnicodeSPI.swift:136:3: warning: Variable Declaration Whitespace Violation: Let and var should be separated from other statements by a blank line. (let_var_whitespace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/UnicodeSPI.swift:146:3: warning: Variable Declaration Whitespace Violation: Let and var should be separated from other statements by a blank line. (let_var_whitespace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/UnicodeSPI.swift:176:3: warning: Variable Declaration Whitespace Violation: Let and var should be separated from other statements by a blank line. (let_var_whitespace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/UnicodeSPI.swift:57:3: warning: Variable Declaration Whitespace Violation: Let and var should be separated from other statements by a blank line. (let_var_whitespace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/UnicodeSPI.swift:65:3: warning: Variable Declaration Whitespace Violation: Let and var should be separated from other statements by a blank line. (let_var_whitespace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/UnicodeScalar.swift:452:3: warning: Variable Declaration Whitespace Violation: Let and var should be separated from other statements by a blank line. (let_var_whitespace)
📖 This PR fixed a violation in WordPress: /WordPress/WordPressIntents/IntentHandler.swift:20:15: warning: Orphaned Doc Comment Violation: A doc comment should be attached to a declaration. (orphaned_doc_comment)
📖 This PR fixed a violation in WordPress: /WordPress/WordPressIntents/IntentHandler.swift:20:19: warning: Orphaned Doc Comment Violation: A doc comment should be attached to a declaration. (orphaned_doc_comment)

Generated by 🚫 Danger

@SimplyDanny
Copy link
Collaborator

The fixed OSS violations are a bit suspicious, aren't they?

@jpsim
Copy link
Collaborator Author

jpsim commented Oct 17, 2022

Yes I’ll need to inspect those.

@jpsim jpsim force-pushed the rewrite-custom_rules-with-swiftsyntax branch from 61576f4 to 4a16db6 Compare October 19, 2022 15:03
@jpsim jpsim force-pushed the rewrite-custom_rules-with-swiftsyntax branch from 620b4b6 to b8f1bd8 Compare October 20, 2022 13:22
@jpsim jpsim marked this pull request as draft October 20, 2022 15:29
@jpsim
Copy link
Collaborator Author

jpsim commented Oct 20, 2022

Moving back to draft. This is going to be pretty challenging to convert.

We may need to offer two modes to run custom_rules in: sourcekit vs swiftsyntax.

@jpsim
Copy link
Collaborator Author

jpsim commented Jun 25, 2025

3 years later... #6129

@jpsim jpsim closed this Jun 25, 2025
@jpsim jpsim deleted the rewrite-custom_rules-with-swiftsyntax branch June 25, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants