[WIP]: prefer unknown default rule experiments #6288
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamieQ
force-pushed
the
unknown-default-rule
branch
from
5631c15 to
d748f0d
Compare
Here's an example of your CHANGELOG entry: * [WIP]: prefer unknown default rule experiments.
[jamieQ](https://github.com/jamieQ)
[#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)note: There are two invisible spaces after the entry's text. Generated by 🚫 Danger |
jamieQ
force-pushed
the
unknown-default-rule
branch
from
d748f0d to
fda9021
Compare
jamieQ
force-pushed
the
unknown-default-rule
branch
from
fda9021 to
17b0f20
Compare
|
@SimplyDanny a (low priority) question for you regarding the CI failures and warnings here – this rule was motivated by the discussion here and would provide a mechanism to check that switch statements do not have 'bare' the integration tests currently appear to be failing due to this issue: is there test fixture i need to opt out of using this rule when it runs those tests, or what is the expected interaction there? additionally there are... a lot of Danger warnings about projects for which this rule would introduce new warnings to if enabled. are these expected? i would expect use of this to be fairly niche, and definitely not something enabled by default – i tried to set that up appropriately in the rule's configuration, so wondering if i've missed something. thanks in advance for your time! |
I approved and ran all actions, so that you can now also see (in the "Files changed" tab of the PR) where the rule would trigger in SwiftLint itself. The fix is to disable the rule in the configuration for this repository, as all rules are enabled by default.
The setup is correct. When we scan OSS repositories, the rule is enabled in any case though. The intention is to get an idea of which effect a code change would have on these projects. It's quite helpful to disclose special cases you haven't thought of in your initial implementation. Important is to verify that all these findings are valid, i.e., they would be expected if one were to enable the rule in the repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.