-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Add new incompatible_concurrency_annotation
rule
#6290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 Danger |
8058b30
to
9ef1c47
Compare
9ef1c47
to
2c64235
Compare
This looks super cool! Thanks so much for doing it. I didn't even think of the generic constraint case! There could be others, like the use of the |
2c64235
to
70087f2
Compare
I've added checking for
Would you agree, @mattmassicotte? I did some experiments as well and haven't seen any changes with or without |
Yeah I wasn't sure about Thanks again for doing this, super cool! |
70087f2
to
1378fac
Compare
1378fac
to
81500d0
Compare
Closes #5987.