Skip to content

Conversation

SimplyDanny
Copy link
Collaborator

Closes #5987.

@SwiftLintBot
Copy link

SwiftLintBot commented Oct 10, 2025

659 Warnings
⚠️ Big PR
⚠️ This PR introduced a violation in Alamofire: /Source/Core/WebSocketRequest.swift:75:16: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/DownloadRequest.swift:446:12: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/DownloadRequest.swift:465:12: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Response.swift:33:8: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Response.swift:215:8: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/DataStreamRequest.swift:34:12: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/DataStreamRequest.swift:48:12: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/DataStreamRequest.swift:523:8: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:220:12: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:235:12: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:484:27: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/Session.swift:1271:12: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/OfflineRetrier.swift:72:12: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/OfflineRetrier.swift:87:24: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/OfflineRetrier.swift:103:24: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/OfflineRetrier.swift:121:12: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/OfflineRetrier.swift:192:19: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/OfflineRetrier.swift:209:19: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/OfflineRetrier.swift:227:19: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/CachedResponseHandler.swift:104:19: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Core/SessionDelegate.swift:234:10: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/RedirectHandler.swift:108:19: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/Concurrency.swift:115:8: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/Concurrency.swift:200:12: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/Concurrency.swift:225:12: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/Concurrency.swift:371:8: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/Concurrency.swift:625:12: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/Concurrency.swift:720:12: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/Concurrency.swift:743:12: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/AuthenticationInterceptor.swift:249:12: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/AuthenticationInterceptor.swift:292:12: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/RequestCompression.swift:64:12: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/RequestCompression.swift:138:19: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/Combine.swift:84:12: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/Combine.swift:304:12: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/Combine.swift:453:12: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/URLEncodedFormEncoder.swift:309:16: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/URLEncodedFormEncoder.swift:332:16: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Alamofire: /Source/Features/ResponseSerialization.swift:462:14: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveVPN/Components/Subscription/BraveVPN+Promotion.swift:13:28: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveVPN/Components/Subscription/BraveVPN+Promotion.swift:32:28: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveVPN/Components/Region/BraveVPN+Region.swift:88:17: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveNews/Composer/FeedDataSource+RSS.swift:88:21: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveNews/Composer/FeedDataSource+RSS.swift:106:21: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Playlist/PlaylistSharedFolder.swift:88:17: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Playlist/PlaylistSharedFolder.swift:138:17: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Playlist/PlaylistSharedFolder.swift:161:17: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveNews/Composer/FeedDataSource.swift:847:21: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Playlist/PlaylistMediaStreamer.swift:38:10: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Playlist/PlaylistManager.swift:379:21: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Playlist/PlaylistManager.swift:440:21: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Playlist/PlaylistManager.swift:475:21: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Playlist/PlaylistManager.swift:508:21: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Playlist/PlaylistManager.swift:940:17: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Playlist/PlaylistManager.swift:967:17: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/SpeechRecognition/SpeechRecognizer.swift:73:10: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Web/WebKit/TabWKDownloadHandler.swift:22:10: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Web/WebKit/TabWKDownloadHandler.swift:48:10: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Web/WebKit/TabWKDownloadHandler.swift:54:10: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BrowserMenu/Action.swift:84:10: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Web/WebKit/SafeJavaScript.swift:49:10: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Web/TabState.swift:286:21: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/DecentralizedDNSHelper.swift:18:19: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/NetworkStore.swift:457:21: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/CryptoStore.swift:795:10: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/WalletUserAssetManager.swift:179:21: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/WalletUserAssetManager.swift:210:21: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/WalletUserAssetManager.swift:265:21: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/WalletUserAssetManager.swift:305:40: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/WalletUserAssetManager.swift:381:40: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/WalletUserAssetManager.swift:403:21: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/WalletUserAssetManager.swift:441:21: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/WalletUserAssetManager.swift:450:21: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/WalletUserAssetManager.swift:501:21: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/WalletUserAssetManager.swift:513:21: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/WalletUserAssetManager.swift:524:21: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/WalletUserAssetManager.swift:733:21: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Extensions/WebImageDownloaderExtensions.swift:10:21: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Extensions/WebImageDownloaderExtensions.swift:19:21: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveStore/Subscription/SDK/BraveSkusSDK.swift:236:10: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveStore/Subscription/SDK/BraveSkusSDK.swift:273:10: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveStore/Subscription/SDK/BraveSkusSDK.swift:303:10: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveStore/Subscription/SDK/BraveSkusSDK.swift:344:10: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveStore/Subscription/SDK/BraveSkusSDK.swift:379:10: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveStore/Subscription/SDK/BraveSkusSDK.swift:411:10: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveStore/Subscription/SDK/BraveSkusSDK.swift:435:10: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveStore/Subscription/SDK/BraveStoreSDK.swift:283:10: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveStore/Subscription/SDK/BraveStoreSDK.swift:330:10: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Favicon/FaviconRenderer.swift:13:17: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Favicon/BundledFaviconRenderer.swift:23:17: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Favicon/BundledFaviconRenderer.swift:174:17: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Shields/BraveShieldsTabHelper+TabPolicyDecider.swift:11:21: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/Playlist/Managers & Cache/PlaylistCoordinator.swift:238:21: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BrowserViewController.swift:3106:10: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BrowserViewController.swift:3304:10: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/WebFilters/FilterListCustomURL.swift:25:21: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/WebFilters/FilterListCustomURL.swift:34:21: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/WebFilters/FilterListResourceDownloader.swift:16:19: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/WebFilters/AdBlock/AdBlockGroupsManager.swift:15:19: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/BraveSkus/BraveSkusManager.swift:31:10: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveTalk/BraveTalkJitsiTranscriptProcessor.swift:37:10: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Migration/Migration.swift:228:28: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveTalk/BraveTalkJitsiCoordinator.swift:13:19: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Growth/URP/AttributionManager.swift:104:21: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Growth/URP/AttributionManager.swift:140:21: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Growth/URP/AttributionManager.swift:188:21: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveShared/Extensions/BraveAdsExtensions.swift:28:21: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveShared/Extensions/AsyncAwait.swift:117:17: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveShared/Extensions/AsyncAwait.swift:156:17: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/AIChat/ModelView/AIChatViewModel.swift:280:10: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveShields/Domain+Extensions.swift:46:21: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveShields/Domain+Extensions.swift:79:27: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveShields/Domain+Extensions.swift:92:27: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveShields/Domain+Extensions.swift:104:27: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveShields/BraveShieldsTabHelper.swift:28:8: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/DataImporter/Utilities/BookmarksImportExportUtility.swift:17:10: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/DataImporter/Utilities/BookmarksImportExportUtility.swift:49:10: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/DataImporter/Utilities/BookmarksImportExportUtility.swift:139:10: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/PlaylistUI/PlayerModel.swift:422:21: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Data/models/FilterListSetting.swift:33:27: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Data/models/FilterListSetting.swift:40:27: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Data/models/FilterListSetting.swift:78:27: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Data/models/FilterListSetting.swift:100:21: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Data/models/CustomFilterListSetting.swift:11:25: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Data/models/WalletUserAsset.swift:195:28: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Data/models/Domain.swift:141:27: Warning: Declaration should be @preconcurrency to maintain compatibility with Swift 5 (incompatible_concurrency_annotation)
⚠️ Danger found 659 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 127.
18 Messages
📖 Building this branch resulted in a binary size of 26351.49 KiB vs 26240.66 KiB when built on main (0% larger).
📖 Linting Aerial with this PR took 0.84 s vs 0.85 s on main (1% faster).
📖 Linting Alamofire with this PR took 1.02 s vs 1.05 s on main (2% faster).
📖 Linting Brave with this PR took 6.87 s vs 6.91 s on main (0% faster).
📖 Linting DuckDuckGo with this PR took 21.86 s vs 21.85 s on main (0% slower).
📖 Linting Firefox with this PR took 10.82 s vs 10.79 s on main (0% slower).
📖 Linting Kickstarter with this PR took 7.6 s vs 7.62 s on main (0% faster).
📖 Linting Moya with this PR took 0.46 s vs 0.46 s on main (0% slower).
📖 Linting NetNewsWire with this PR took 2.4 s vs 2.38 s on main (0% slower).
📖 Linting Nimble with this PR took 0.65 s vs 0.68 s on main (4% faster).
📖 Linting PocketCasts with this PR took 6.71 s vs 6.81 s on main (1% faster).
📖 Linting Quick with this PR took 0.4 s vs 0.39 s on main (2% slower).
📖 Linting Realm with this PR took 3.31 s vs 3.31 s on main (0% slower).
📖 Linting Sourcery with this PR took 1.85 s vs 1.82 s on main (1% slower).
📖 Linting Swift with this PR took 4.25 s vs 4.2 s on main (1% slower).
📖 Linting VLC with this PR took 1.16 s vs 1.15 s on main (0% slower).
📖 Linting Wire with this PR took 17.31 s vs 17.3 s on main (0% slower).
📖 Linting WordPress with this PR took 11.34 s vs 11.34 s on main (0% slower).

Generated by 🚫 Danger

@SimplyDanny SimplyDanny force-pushed the incompatible-concurrency-annotation branch from 8058b30 to 9ef1c47 Compare October 10, 2025 20:53
@SimplyDanny SimplyDanny force-pushed the incompatible-concurrency-annotation branch from 9ef1c47 to 2c64235 Compare October 10, 2025 21:22
@mattmassicotte
Copy link

This looks super cool! Thanks so much for doing it.

I didn't even think of the generic constraint case! There could be others, like the use of the sending keyword. I'm not exactly sure and it would take some experimenting to figure out. But this is wonderful regardless!

@SimplyDanny SimplyDanny force-pushed the incompatible-concurrency-annotation branch from 2c64235 to 70087f2 Compare October 15, 2025 19:01
@SimplyDanny
Copy link
Collaborator Author

There could be others, like the use of the sending keyword. I'm not exactly sure and it would take some experimenting to figure out.

I've added checking for sending keywords. However, I think that it's not needed because of the statement about source compatibility in the introducing proposal:

In the Swift 5 language mode, sending diagnostics are suppressed under minimal concurrency checking, and diagnosed as warnings under strict concurrency checking. The diagnostics are errors in the Swift 6 language mode, as shown in the code examples in this proposal. This diagnostic behavior based on language mode allows sending to be adopted in existing Concurrency APIs including CheckedContinuation.

Would you agree, @mattmassicotte? I did some experiments as well and haven't seen any changes with or without @preconcurrency. That doesn't mean much, though, as I'm not sure whether my examples have been sufficient.

@mattmassicotte
Copy link

Yeah I wasn't sure about sending, parameters in particular. But that text does seem unambiguous, and the biggest culprits are global actors and @Sendable anyways. So I think this will provide very good coverage.

Thanks again for doing this, super cool!

@SimplyDanny SimplyDanny force-pushed the incompatible-concurrency-annotation branch from 70087f2 to 1378fac Compare October 20, 2025 17:29
@SimplyDanny SimplyDanny force-pushed the incompatible-concurrency-annotation branch from 1378fac to 81500d0 Compare October 20, 2025 17:32
@SimplyDanny SimplyDanny enabled auto-merge (squash) October 20, 2025 17:32
@SimplyDanny SimplyDanny merged commit 70a2e6c into main Oct 20, 2025
25 checks passed
@SimplyDanny SimplyDanny deleted the incompatible-concurrency-annotation branch October 20, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rule to check for Swift 5-mode-incompatible API

3 participants