[DeadCode] Add fixture to keep constructor params with autowire attribute

[darthf1]

RemoveParentDelegatingConstructorRector removes the constructor of class DoSomething. But the $filterLocator param has an autowire attribute so it doesn't just delegates the variable to the parent but it also adds metadata and I expect it to be kept as-is.

[samsonasik]

Could you provide documentation link when add autowire attribute on __construct matter so it can be future note why it is to be skipped?

[darthf1]

You mean a link like https://symfony.com/doc/current/service_container/autowiring.html?

Autowiring allows you to manage services in the container with minimal configuration. It reads the type-hints on your constructor (or other methods) and automatically passes the correct services to each method.

Do you want it in the fixture? Or just here?

[samsonasik]

Add to fixture is fine, move parent class under Source

[darthf1]

You could probably give the same arguments for other attributes as well:

from https://symfony.com/doc/current/reference/attributes.html#dependency-injection:
Autowire
AutowireCallable
AutowireDecorated
AutowireIterator
AutowireLocator
AutowireMethodOf
AutowireServiceClosure
Lazy
Target

[samsonasik]

move this class under Source

https://github.com/rectorphp/rector-src/tree/main/rules-tests/DeadCode/Rector/ClassMethod/RemoveParentDelegatingConstructorRector/Source

[darthf1]

Its hard to do it in the web interface ;) Ill come back later and do it through the IDE.

[TomasVotruba]

@darthf1 Let's close this one then. Feel free to open a up a new PR from the IDE 👍