Playbook and Role to move objects from one storage bucket into another #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abikouo
force-pushed
the
move_objects_v1
branch
from
8444277 to
9acafd6
Compare
gravesm
reviewed
Aug 22, 2023
#5 has been created for gcp_setup_credentials role |
Comment on lines
+5
to
+7
| auth_kind: "{{ gcp_auth_kind }}" | ||
| service_account_file: "{{ gcp_cred_file }}" | ||
| project: "{{ gcp_project }}" |
There was a problem hiding this comment.
Why don't you use the role for creds setting here?
There was a problem hiding this comment.
I can also do that, I was just using it for collection role, but it should work too
|
We can leave this PR open in case things change, but we do not want to merge this as the limitations of the google.cloud collection prevent us from properly implementing this use case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to limitation with google.cloud collection, this role/playbook cannot delete source storage bucket as we can't list objects from one bucket (cannot delete non empty storage bucket), users also needs to provided list of objects to move.
#5 should be merged first for the CI to pass on this one