Skip to content

Conversation

@adietish
Copy link
Collaborator

@adietish adietish commented Oct 23, 2025

does not fix eclipse-che/che#23587, it's only related to it.
only provides a small fix that allows port-forwarding to heal if it breaks while copying streams.

@adietish adietish self-assigned this Oct 23, 2025
@adietish adietish requested a review from vrubezhny October 23, 2025 08:51
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 3.55%. Comparing base (71098f6) to head (8e708ed).
⚠️ Report is 243 commits behind head on main.

Files with missing lines Patch % Lines
...tlin/com/redhat/devtools/gateway/openshift/Pods.kt 41.66% 4 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #200      +/-   ##
========================================
+ Coverage   0.00%   3.55%   +3.55%     
========================================
  Files          4      32      +28     
  Lines         26    1181    +1155     
  Branches       0     208     +208     
========================================
+ Hits           0      42      +42     
- Misses        26    1133    +1107     
- Partials       0       6       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Andre Dietisheim <adietish@redhat.com>
@adietish adietish changed the title fix: reinitiate port forwarding when it is closed (#23587) fix: close streams when portforwarding is closed while copying Oct 23, 2025
Copy link
Member

@azatsarynnyy azatsarynnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @adietish
I tested the patch by selecting File > Invalidate caches > Just Restart,
and there's a Connecting to remote host... window that stays forever:

Image

If I understand correctly, it should reconnect the IDE.

@adietish
Copy link
Collaborator Author

adietish commented Oct 23, 2025

@azatsarynnyy: This PR is only a small fix for the port forwarding (Commit 1, eclipse-che/che#23587 (comment)).
There's no good solution to the connecting-dialog imho:
The best I could achieve is a solution where it would reconnect automatically after 30s, the dialog stayed opened (see Commit 2, eclipse-che/che#23587 (comment)). Given that this isn't a good solution and the approach to achieve it is repeatedly querying of remote-dev-server status (via pod-exec), I thought of dropping it, leaving the issue as KNOWN ISSUE. Leaving the small fix of Commit 1 which is this PR here.
I'll post a comment to the jetbrains forum and hope that they fix the issue on their side.
Agree?

@adietish adietish changed the title fix: close streams when portforwarding is closed while copying fix: close streams when portforwarding is closed while copying (#23587) Oct 23, 2025
@adietish adietish merged commit 84e3222 into redhat-developer:main Oct 23, 2025
5 checks passed
@adietish adietish deleted the issue-23587_2 branch October 23, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gateway: cannot automatically reconnect after restarting remote IDE

3 participants