Skip to content

Conversation

JessicaJHee
Copy link
Member

Description

Fixes bug by reading configured host from integrations.<providerId>.host instead of calling ScmAuth.createDefaultApiFactory(), which only supports default provider hosts (falls back to default URL if host option is not provided).

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

  1. Configure GitLab Enterprise integration with self-hosted/ enterprise host in app-config
integrations:
  gitlab:
    - host: gitlab.company.com
  1. Attempt to use a software template with:
          ui:field: RepoUrlPicker
          ui:options:
            allowedHosts:
              - gitlab.company.com
  1. Ensure No auth provider available for 'https://gitlab.company.com' error does not appear

Signed-off-by: Jessica He <jhe@redhat.com>
Copy link
Contributor

@JessicaJHee JessicaJHee requested a review from albarbaro August 21, 2025 18:28
@albarbaro
Copy link
Member

/lgtm
/approve

@albarbaro
Copy link
Member

/lgtm

Copy link

openshift-ci bot commented Sep 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: albarbaro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c7dc334 into redhat-developer:main Sep 3, 2025
15 of 17 checks passed
guyoron1 pushed a commit to guyoron1/rhdh that referenced this pull request Sep 29, 2025
Signed-off-by: Jessica He <jhe@redhat.com>
Co-authored-by: Alessandro Barbarossa <abarbaro@redhat.com>
@kim-tsao
Copy link
Member

kim-tsao commented Oct 9, 2025

/cherrypick release-1.7

@openshift-cherrypick-robot
Copy link
Contributor

@kim-tsao: new pull request created: #3530

In response to this:

/cherrypick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants