-
Notifications
You must be signed in to change notification settings - Fork 205
fix: support custom hosts for SCM auth #3309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support custom hosts for SCM auth #3309
Conversation
Signed-off-by: Jessica He <jhe@redhat.com>
The image is available at: |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: albarbaro The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c7dc334
into
redhat-developer:main
Signed-off-by: Jessica He <jhe@redhat.com> Co-authored-by: Alessandro Barbarossa <abarbaro@redhat.com>
/cherrypick release-1.7 |
@kim-tsao: new pull request created: #3530 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
Fixes bug by reading configured host from
integrations.<providerId>.host
instead of callingScmAuth.createDefaultApiFactory()
, which only supports default provider hosts (falls back to default URL if host option is not provided).Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer
No auth provider available for 'https://gitlab.company.com'
error does not appear