feat: allow tag omission in OCI references for dynamic plugins #3352

Zaperex · 2025-09-02T16:48:50Z

Description

Adds support for dynamic plugin version inheritance for OCI packages via a {{inherit}} tag.
Script also now throws an error if duplicate plugins are found across config files in the includes field.
- It also throws errors if there are duplicate plugins in the dynamic-plugins.yaml.
- Essentially any duplicates found in the same "level" will throw an error.

Which issue(s) does this PR fix

Fixes RHIDP-8215?

PR acceptance criteria

Please make sure that the following steps are complete:

GitHub Actions are completed and successful
Unit Tests are updated and passing
E2E Tests are updated and passing
Documentation is updated if necessary (requirement for new features)
Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Signed-off-by: Frank Kong <frkong@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

Zaperex · 2025-09-02T18:20:29Z

/retest

Signed-off-by: Frank Kong <frkong@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

… and current info. Signed-off-by: Frank Kong <frkong@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

github-actions · 2025-09-04T20:12:18Z

The image is available at:

docker/install-dynamic-plugins.py

docs/dynamic-plugins/installing-plugins.md

docker/install-dynamic-plugins.py

Signed-off-by: Frank Kong <frkong@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

github-actions · 2025-09-08T15:15:05Z

The image is available at:

Signed-off-by: Frank Kong <frkong@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

…with tag/digest Signed-off-by: Frank Kong <frkong@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

github-actions · 2025-09-08T22:25:50Z

The image is available at:

github-actions · 2025-09-08T23:53:00Z

The image is available at:

gashcrumb · 2025-09-09T10:58:27Z

docker/install-dynamic-plugins.py

    # if `package` already exists in `allPlugins`, then override its fields
    if package not in allPlugins:
+        if package.startswith('oci://'):
+            if inheritVersion is True:


Is there any way to reduce the nested if statements here and on line 165-166? This kind of nesting tends to lead to difficult to follow logic, and if we make this kind of test more than once maybe it'd be more clear in intent to have a helper function that makes this test.

@gashcrumb do you consider it resolved ?

github-actions · 2025-10-04T01:59:54Z

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days.

docs/dynamic-plugins/installing-plugins.md

github-actions · 2025-10-08T18:23:26Z

The image is available at:

Signed-off-by: Frank Kong <frkong@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

Signed-off-by: Frank Kong <frkong@redhat.com> Assisted-by: Cursor rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

Signed-off-by: Frank Kong <frkong@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

…ynamic-plugin-install-script rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

github-actions · 2025-10-14T16:45:06Z

The image is available at:

Signed-off-by: Frank Kong <frkong@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

github-actions · 2025-10-14T18:29:22Z

The image is available at:

Signed-off-by: Frank Kong <frkong@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

…ynamic-plugin-install-script rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

Signed-off-by: Frank Kong <frkong@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

github-actions · 2025-10-17T22:03:55Z

The image is available at:

openshift-ci · 2025-10-17T22:07:05Z

@Zaperex: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-tests	`57ee712`	link	true	`/test e2e-tests`
ci/prow/e2e-ocp-helm	`77cc2c5`	link	true	`/test e2e-ocp-helm`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Zaperex added 3 commits September 2, 2025 12:33

feat: add version inheritance for OCI dynamic plugins

e95c68e

Signed-off-by: Frank Kong <frkong@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

feat: add sha digest support for inheritVersion

03fb2cf

Signed-off-by: Frank Kong <frkong@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

docs: add inheritVersion docs

31007ad

Signed-off-by: Frank Kong <frkong@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

openshift-ci bot requested review from dzemanov and its-mitesh-kumar September 2, 2025 16:48

Zaperex requested review from davidfestal and removed request for dzemanov and its-mitesh-kumar September 2, 2025 16:49

Merge branch 'main' into update-dynamic-plugin-install-script

01bac0a

Zaperex temporarily deployed to internal September 2, 2025 16:49 — with GitHub Actions Inactive

Zaperex added 3 commits September 3, 2025 15:43

chore: use {{inherit}} placeholder tag instead of inheritVersion field

70ff250

Signed-off-by: Frank Kong <frkong@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

chore: add dupe conflict detection in plugin config

f581288

Signed-off-by: Frank Kong <frkong@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

chore: modify update message condition

fd56cbc

Signed-off-by: Frank Kong <frkong@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

Zaperex temporarily deployed to internal September 4, 2025 19:17 — with GitHub Actions Inactive

docs: update dynamic plugin install docs with new tag/digest inherit,…

692d1b1

… and current info. Signed-off-by: Frank Kong <frkong@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

Zaperex force-pushed the update-dynamic-plugin-install-script branch from 3762a9c to 692d1b1 Compare September 4, 2025 19:18

Zaperex temporarily deployed to internal September 4, 2025 19:18 — with GitHub Actions Inactive

davidfestal reviewed Sep 8, 2025

View reviewed changes

chore: update docs based on suggestions

b0e8dd9

Signed-off-by: Frank Kong <frkong@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

Zaperex temporarily deployed to internal September 8, 2025 14:18 — with GitHub Actions Inactive

Zaperex added 2 commits September 8, 2025 17:02

chore: update supported algorithms to match OCI registered algorithms

730ad96

Signed-off-by: Frank Kong <frkong@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

chore: error out if {{inherit}} is used without an existing config …

fe2525e

…with tag/digest Signed-off-by: Frank Kong <frkong@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

Merge branch 'main' into update-dynamic-plugin-install-script

4520f84

Zaperex requested a review from davidfestal September 8, 2025 22:55

gashcrumb reviewed Sep 9, 2025

View reviewed changes

github-actions bot added the Stale label Oct 4, 2025

christoph-jerolimov reviewed Oct 4, 2025

View reviewed changes

docs/dynamic-plugins/installing-plugins.md Show resolved Hide resolved

github-actions bot removed the Stale label Oct 5, 2025

Merge branch 'main' into update-dynamic-plugin-install-script

35f9e3f

nickboldt temporarily deployed to internal October 8, 2025 17:27 — with GitHub Actions Inactive

Zaperex temporarily deployed to internal October 14, 2025 15:20 — with GitHub Actions Inactive

Zaperex temporarily deployed to internal October 14, 2025 15:44 — with GitHub Actions Inactive

Zaperex added 5 commits October 14, 2025 11:47

feat: add npm package key handling

178a277

Signed-off-by: Frank Kong <frkong@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

test: add initial unit tests for package key extraction

82960b0

Signed-off-by: Frank Kong <frkong@redhat.com> Assisted-by: Cursor rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

chore: move dev requirements file to python folder

026f8e6

Signed-off-by: Frank Kong <frkong@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

chore: add python unit test to gh pr workflow

487c588

Signed-off-by: Frank Kong <frkong@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

Merge branch 'main' of github.com:redhat-developer/rhdh into update-d…

0f78161

…ynamic-plugin-install-script rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

Zaperex force-pushed the update-dynamic-plugin-install-script branch from 6fd29a5 to 0f78161 Compare October 14, 2025 15:49

Zaperex temporarily deployed to internal October 14, 2025 15:49 — with GitHub Actions Inactive

chore: fix npm package override and add unit tests for package merging

78f2e6e

Signed-off-by: Frank Kong <frkong@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

Zaperex temporarily deployed to internal October 14, 2025 17:32 — with GitHub Actions Inactive

Zaperex added 2 commits October 17, 2025 15:45

chore: add more unit tests for the npm package installer

70e428b

Signed-off-by: Frank Kong <frkong@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

chore: add symlink and hardlink unit test check for npm package extract

f890e53

Signed-off-by: Frank Kong <frkong@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

Zaperex temporarily deployed to internal October 17, 2025 19:53 — with GitHub Actions Inactive

chore: add unit tests for the OCI package installer

9498951

Signed-off-by: Frank Kong <frkong@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

Zaperex temporarily deployed to internal October 17, 2025 20:53 — with GitHub Actions Inactive

Zaperex added 2 commits October 17, 2025 16:54

Merge branch 'main' of github.com:redhat-developer/rhdh into update-d…

88209aa

…ynamic-plugin-install-script rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

chore: update dev requirements.txt

77cc2c5

Signed-off-by: Frank Kong <frkong@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

Zaperex deployed to internal October 17, 2025 20:56 — with GitHub Actions Active

feat: allow tag omission in OCI references for dynamic plugins #3352

Are you sure you want to change the base?

feat: allow tag omission in OCI references for dynamic plugins #3352

Uh oh!

Conversation

Zaperex commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Which issue(s) does this PR fix

PR acceptance criteria

How to test changes / Special notes to the reviewer

Uh oh!

Zaperex commented Sep 2, 2025

Uh oh!

github-actions bot commented Sep 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Sep 8, 2025

Uh oh!

github-actions bot commented Sep 8, 2025

Uh oh!

github-actions bot commented Sep 8, 2025

Uh oh!

gashcrumb Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

davidfestal Oct 4, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 4, 2025

Uh oh!

Uh oh!

github-actions bot commented Oct 8, 2025

Uh oh!

github-actions bot commented Oct 14, 2025

Uh oh!

github-actions bot commented Oct 14, 2025

Uh oh!

github-actions bot commented Oct 17, 2025

Uh oh!

openshift-ci bot commented Oct 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Zaperex commented Sep 2, 2025 •

edited

Loading