Skip to content

Conversation

ciiay
Copy link
Member

@ciiay ciiay commented Sep 30, 2025

Description

This PR bumps the topology plugin version and includes the translation resources to RHDH.

Which issue(s) does this PR fix

  • Fixes #?

For RHIDP-9104

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Verified working on a cluster

pr_3493.mp4

Copy link
Contributor

Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/retest

@christoph-jerolimov
Copy link
Member

/retest

1 similar comment
@christoph-jerolimov
Copy link
Member

/retest

@debsmita1
Copy link
Member

/test e2e-ocp-helm

Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ciiay @debsmita1 e2e is failing because of an issue in the topology plugin.

With the i18n the missing permission page didn't pass the tests and actually I think that check is correct. See:

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/redhat-developer_rhdh/3493/pull-ci-redhat-developer-rhdh-main-e2e-ocp-helm/1973254215790759936/artifacts/e2e-ocp-helm/redhat-developer-rhdh-ocp-helm/artifacts/showcase-rbac/index.html#?testId=82f3c7b94a4e23add5ec-f7499d2d0f1d53a9b707

So I raised an upstream PR which is now merged and released. See:

Can you please update topology in this PR to 2.6.1 to see if the e2e tests passes with this changes.

@christoph-jerolimov
Copy link
Member

/lgtm cancel

@christoph-jerolimov
Copy link
Member

/retest

@ciiay ciiay force-pushed the rhidp-9104-update-topology-wrapper branch from 83597e0 to db1cfe0 Compare October 1, 2025 20:25
Copy link
Contributor

github-actions bot commented Oct 1, 2025

@christoph-jerolimov
Copy link
Member

/retest

1 similar comment
@christoph-jerolimov
Copy link
Member

/retest

@ciiay
Copy link
Member Author

ciiay commented Oct 2, 2025

/test e2e-ocp-helm

@ciiay
Copy link
Member Author

ciiay commented Oct 2, 2025

This version of Topology runs into the following error when tested on a cluster. @debsmita1 @karthikjeeyar @Eswaraiahsapram We will need to look into the useKubernetesObjects reference.
image

Copy link
Contributor

Comment on lines +225 to +227
translationResources:
- importName: topologyTranslations
ref: topologyTranslationRef
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
translationResources:
- importName: topologyTranslations
ref: topologyTranslationRef
translationResources:
- importName: topologyTranslations
ref: topologyTranslationRef
module: Alpha

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 🤝

ciiay added 11 commits October 15, 2025 08:03
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
@ciiay ciiay force-pushed the rhidp-9104-update-topology-wrapper branch from 4ca68da to 5bd52f3 Compare October 15, 2025 12:23
Copy link
Contributor

Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Oct 15, 2025
Copy link

openshift-ci bot commented Oct 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christoph-jerolimov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [christoph-jerolimov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 02944c6 into redhat-developer:main Oct 15, 2025
17 checks passed
@invincibleJai
Copy link
Member

/cherrypick release-1.8

@openshift-cherrypick-robot
Copy link
Contributor

@invincibleJai: new pull request created: #3557

In response to this:

/cherrypick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants