-
Notifications
You must be signed in to change notification settings - Fork 205
chore(deps): bump topology plugin version #3493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump topology plugin version #3493
Conversation
The image is available at: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/retest
/retest |
1 similar comment
/retest |
/test e2e-ocp-helm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ciiay @debsmita1 e2e is failing because of an issue in the topology plugin.
With the i18n the missing permission page didn't pass the tests and actually I think that check is correct. See:
So I raised an upstream PR which is now merged and released. See:
Can you please update topology in this PR to 2.6.1 to see if the e2e tests passes with this changes.
/lgtm cancel |
/retest |
83597e0
to
db1cfe0
Compare
The image is available at: |
/retest |
1 similar comment
/retest |
/test e2e-ocp-helm |
This version of Topology runs into the following error when tested on a cluster. @debsmita1 @karthikjeeyar @Eswaraiahsapram We will need to look into the |
The image is available at: |
translationResources: | ||
- importName: topologyTranslations | ||
ref: topologyTranslationRef |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
translationResources: | |
- importName: topologyTranslations | |
ref: topologyTranslationRef | |
translationResources: | |
- importName: topologyTranslations | |
ref: topologyTranslationRef | |
module: Alpha |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch 🤝
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
4ca68da
to
5bd52f3
Compare
The image is available at: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christoph-jerolimov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
02944c6
into
redhat-developer:main
/cherrypick release-1.8 |
@invincibleJai: new pull request created: #3557 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
This PR bumps the topology plugin version and includes the translation resources to RHDH.
Which issue(s) does this PR fix
For RHIDP-9104
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer
Verified working on a cluster
pr_3493.mp4