Skip to content

Use the new method of validation. #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Use the new method of validation. #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions coremark/base_test_results/test1/verify
View file
Open in desktop

This file was deleted.

15 changes: 6 additions & 9 deletions coremark/coremark_run
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ coremark_version="v1.01"
test_name="coremark"
results_file="results_${test_name}.csv"
arguments="$@"
rtc=0

exit_out()
{
Expand Down Expand Up @@ -253,13 +254,10 @@ generate_results()
fi

if [ $to_pbench -eq 0 ]; then
lines=`wc -l $results_file | cut -d' ' -f1`
if [ $lines -lt 2 ]; then
echo Failed > test_results_report
else
echo Ran > test_results_report
fi
${curdir}/test_tools/save_results --curdir $curdir --home_root $to_home_root --other_files "*_summary,run*log,test_results_report" --results $results_file --test_name coremark --tuned_setting=$to_tuned_setting --version $coremark_version --user $to_user
$TOOLS_BIN/csv_to_json $to_json_flags --csv_file ${results_file} --output_file ${test_name}.json
$TOOLS_BIN/verify_results $to_verify_flags --file ${test_name}.json --schema_file $to_script_dir/result_schema.py --class_name CoremarkResults
rtc=$?
${TOOLS_BIN}/save_results --curdir $curdir --home_root $to_home_root --other_files "*json,*_summary,run*log,test_results_report" --results $results_file --test_name coremark --tuned_setting=$to_tuned_setting --version $coremark_version --user $to_user
fi
popd > /dev/null
}
Expand Down Expand Up @@ -401,5 +399,4 @@ else
run_coremark
generate_results
fi
exit 0

exit $rtc
5 changes: 5 additions & 0 deletions coremark/result_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import pydantic
class CoremarkResults(pydantic.BaseModel):
iteration: int = pydantic.Field(description="Iteration", gt=0)
threads: int = pydantic.Field(description="How many threads we ran.", gt=0)
test_passes: float = pydantic.Field(description="Number of test passes", allow_inf_nan=False, gt=0, validation_alias="test passes")
4 changes: 0 additions & 4 deletions coremark/verification_config/test_verify
View file
Open in desktop

This file was deleted.

Loading