Skip to content

Conversation

justin-cechmanek
Copy link
Contributor

No description provided.

@tylerhutcherson tylerhutcherson added enhancement New feature or request documentation Improvements or additions to documentation labels Oct 15, 2024
@tylerhutcherson
Copy link
Collaborator

Nice work! My feedback below, just a few things!!

  • Link back to content filtering notebook/recipe up top to help people who may be new or are getting started go through the easier example first?
  • The explanation of the range query score output as it relates to rating predictions could be clearer (should we have a helper method to convert this value?)
  • Consider storing the user items in a separate index to handle two things -- storage of users/metadata/vectors in a more production like way. Retriever user from DB and then do the inference? Just an idea.
  • Love the bloom filter approach, but I think we need to lay the baseline with just standard title/ID based filtering using a TAG filter first. And then build to why a bloom filter works here and what problem it solves.

Copy link
Collaborator

@rbs333 rbs333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really awesome recipe! Tyler's comments are good and I would also say to add a link to this in the root level readme.

@justin-cechmanek justin-cechmanek merged commit bc10d2e into main Oct 18, 2024
1 check passed
@justin-cechmanek justin-cechmanek deleted the feat/RAAE-312/collaborative-filtering branch October 18, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants