Skip to content

Conversation

kimsunghyun1995
Copy link
Contributor

This PR removes the deprecated withPassword(String) method from RedisURI.Builder as discussed in #3328.

Important Note:

Existing code that calls withPassword(String) will continue to work without modification because:

  • String implements CharSequence
  • All existing string parameters will automatically route to withPassword(CharSequence) method
  • The functionality remains identical

This approach minimizes the breaking change impact while still removing the deprecated method. All existing tests continue to pass without modification.

This PR is a follow-up to #1157 and addresses part of #3328.

Checklist

  • I have read the contribution guidelines.
  • I have created a feature request first to discuss my contribution intent.
  • I applied code formatting rules using the mvn formatter:format target. No formatting-related changes included.
  • Documentation-only change, no test cases needed.

@kimsunghyun1995 kimsunghyun1995 changed the title Remove deprecated withPassword(String) method (#3328) chore: deprecated withPassword(String) method (#3328) Jul 8, 2025
@tishun tishun force-pushed the remove-deprecated-withPassword-string-method branch from 01af270 to d679c17 Compare July 10, 2025 15:14
@tishun tishun added the type: breaking Breaking change label Jul 10, 2025
@tishun tishun added this to the 7.0.0.RELEASE milestone Jul 10, 2025
@tishun tishun merged commit 9eaaba9 into redis:main Aug 8, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: breaking Breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants