fix write race condition when slot migration #3361
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that:
mvn formatter:format
target. Don’t submit any formatting related changes.This PR fixes the issue where during slot migration(#3353 ), there might be concurrent writes of other commands between the asking command and the actual command. It achieves this by modifying the
writeToChannelAndFlush(Channel channel, Collection<?
extends RedisCommand> commands), changing the original method of writing to the channel using a for loop to directly writing the list to the channel, thus avoiding the aforementioned issue.