Leverage default generic useEntityMutation function definition #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebbourg
approved these changes
Apr 2, 2025
Collaborator
calebbourg
left a comment
calebbourg
left a comment
There was a problem hiding this comment.
@zgavin1 Nice job! I must have done something weird when I was trying this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement a default generic type for the second argument of the
useEntityMutationhook, makes it cleaner to use across the different entity specific-hooks which may or may not need the second type.GitHub Issue: Closes #20
Changes
Screenshots / Videos Showing UI Changes (if applicable)
Testing Strategy
describe how you or someone else can test and verify the changes
Concerns
Not totally sure why this didn't work when Caleb tried - may have just been a typechecker hiccup that day.