Refactor the backend API to match what the frontend already correctly does for logout #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… expects for logout --> delete /user_sessions/:id
calebbourg
approved these changes
Apr 8, 2025
| pub async fn logout(mut auth_session: AuthSession) -> impl IntoResponse { | ||
| debug!("UserSessionController::logout()"); | ||
| pub async fn delete(mut auth_session: AuthSession) -> impl IntoResponse { | ||
| trace!("UserSessionController::delete()"); |
Collaborator
There was a problem hiding this comment.
curious on the choice to use trace! over debug ?
Member
Author
There was a problem hiding this comment.
I was thinking that function call console output is kind of the definition of trace and perhaps we are ready to start migrating the rest over to use trace as well?
github-project-automation
bot
moved this from Review
to ✅ Done
in Refactor Coaching Platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the backend endpoint for logout and changes it to be deletion of a user_session with an id.
GitHub Issue: None
Changes
Testing Strategy
Concerns
None