nsis: add missing file.close() #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

GerardoAllende wants to merge 1 commit into reingart:develop from GerardoAllende:patch-1

Contributor

GerardoAllende commented Apr 13, 2025

Summary

Missing file.close() can cause errors when file is read before the garbage collector closes the file.

Checklist

Classes, Variables, function and methods logic ok
Comments written explaining what the code does
All python code is PEP8 compliant (run black .)
No lint issues (run flake8)
Test coverage with pytest implemented
Reviewers assigned (at least 1 mentor)

Manual test evidence

(attach command-line examples, execution output & logs, etc.)


          nsis: add missing file.close()

6346e5a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet