Skip to content

Conversation

@cknitt
Copy link
Member

@cknitt cknitt commented Nov 25, 2025

After installing with npm, with the current lockfile, I was getting

Error: Cannot find module @rollup/rollup-darwin-arm64. npm has a bug related to optional dependencies (npm/cli#4828). Please try npm i again after removing both package-lock.json and node_modules directory.

I think we should move to yarn anyway to match what we have in the main rescript repo.

This also helps us to get rid of patch-package by using yarn's built-in patching functionality.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 25, 2025

Deploying rescript-lang-org with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1a43160
Status: ✅  Deploy successful!
Preview URL: https://6f04fa85.rescript-lang.pages.dev
Branch Preview URL: https://yarn.rescript-lang.pages.dev

View logs

Copy link
Member

@tsnobip tsnobip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks a lot @cknitt!

@cknitt cknitt merged commit 8f6c7b2 into master Nov 25, 2025
2 checks passed
@cknitt cknitt deleted the yarn branch November 25, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants