Improve Exception to NSError conversion #31
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The current implementation uses compiler internals which causes issues when the |
rickclephas
commented
Feb 20, 2022
| fun IrDeclaration.getAnnotation(): IrConstructorCall? = | ||
| annotations.findNativeCoroutineThrowsAnnotation() ?: | ||
| useThrowsAnnotation.ifTrue { originalDeclaration.annotations.findThrowsAnnotation() } ?: | ||
| parentClassOrNull?.getAnnotation() |
There was a problem hiding this comment.
Maybe this should just use all the annotations, would probably make more sense since the propagatedExceptions are also applied (even if the function has an annotation).
rickclephas
force-pushed
the
feature/GH-29-improve-exception-conversion
branch
from
5bf1ea0 to
fc884ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29