Implements send and target expressions #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moves ExpressionCompiler to validator/ folder for better organization - Adds comprehensive ExpressionCompiler tests with >90% coverage (91.2%) - Replaces `assert not` with `refute` in tests for proper Elixir conventions - Moves all expression compilation from creation-time to validation-time - Adds compilation warning collection with detailed error context - Implements fallback runtime compilation for backward compatibility - Supports all action types: transitions, SendAction, AssignAction, IfAction, ForeachAction - Adds source location tracking for better debugging 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Refactors SendAction evaluation functions to reduce cyclomatic complexity from 11 to <3 - Extracts common expression evaluation logic into reusable helper functions - Reorders function arguments to put state_chart first for better pipeline support - Uses pattern matching with guards instead of cond for cleaner control flow - Fixes unused variable naming consistency (uses _meaningful_name instead of _) - Maintains all existing functionality and test coverage - Improves maintainability through DRY principles and cleaner abstractions 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Updates all action execute functions to take state_chart as the first argument, enabling better pipeline composition with the |> operator. - Updates execute function signatures in all action modules - Updates ActionExecutor calls to match new argument order - Updates all action tests to use new calling convention - Maintains full backward compatibility through function clauses - Enables idiomatic Elixir pipeline patterns for state chart threading 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds comprehensive expression compilation during document validation and makes all actions pipeline-friendly for better Elixir ergonomics.
Expression Compilation Improvements
Pipeline-Friendly Architecture
state_chartas the first argument|>operatorCode Quality Improvements
Performance Benefits
Example Usage