rebase vector branch to latest #1021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the spec. This is required for several use cases like Go risc-v support which relies only on 64-bit spec, thus being able to filter rv32 CSRs is mandatory. (#532) Signed-off-by: Afonso Oliveira <Afonso.Oliveira@synopsys.com> Co-authored-by: Derek Hower <134728312+dhower-qc@users.noreply.github.com>
Co-authored-by: Your Name <your.email@example.com> Co-authored-by: Derek Hower <134728312+dhower-qc@users.noreply.github.com>
…nt extension (#543) Signed-off-by: Albert Yosher <quic_ayosher@quicinc.com>
* Separate Zcf and Zcd extensions from Zce Signed-off-by: Albert Yosher <quic_ayosher@quicinc.com> * Restore per-instruction dependencies of Zcf/Zcd Signed-off-by: Albert Yosher <quic_ayosher@quicinc.com> --------- Signed-off-by: Albert Yosher <quic_ayosher@quicinc.com>
* Xqci/Xqcibm extension: fix some representation issues, fix qc.extdur rs1 != 31 Signed-off-by: Albert Yosher <quic_ayosher@quicinc.com> * Xqci: fix asciidoc formatting in description * gen:adoc fix asciidoc generation of IDL csr read * gen:ext_pdf fix implication list; improve version display * Add missing word 'CSRs' in CSR summary generation Signed-off-by: Albert Yosher <quic_ayosher@quicinc.com> --------- Signed-off-by: Albert Yosher <quic_ayosher@quicinc.com> Co-authored-by: Albert Yosher <quic_ayosher@quicinc.com>
* Add initial Golang generation support. Signed-off-by: Afonso Oliveira <Afonso.Oliveira@synopsys.com> * Enhance go generator to allow filtering by extensions * Enhance Go CSR generation by filtering out unused extensions and define set of extensions that GO currently supports. Signed-off-by: Afonso Oliveira <Afonso.Oliveira@synopsys.com> * update checked out version of inst.go changed by latest commits. Signed-off-by: Afonso Oliveira <Afonso.Oliveira@synopsys.com> * Refactor to ensure reusable code, given the extensibility of outputs generator.py may be used to generate. Signed-off-by: Afonso Oliveira <Afonso.Oliveira@synopsys.com> * Fix Go awkward struct spacing. Signed-off-by: Afonso Oliveira <Afonso.Oliveira@synopsys.com> * Add rake task to generate Golang input - inst.go Signed-off-by: Afonso Oliveira <Afonso.Oliveira@synopsys.com> * Add CSR ordering to match riscv-opcodes. Signed-off-by: Afonso Oliveira <Afonso.Oliveira@synopsys.com> * Remove checked out inst.go Signed-off-by: Afonso Oliveira <Afonso.Oliveira@synopsys.com> * Update all spacing to exactly match riscv-opcodes. Signed-off-by: Afonso Oliveira <Afonso.Oliveira@synopsys.com> * Change check_requirement due to being out of scope for go_generator call. Signed-off-by: Afonso Oliveira <Afonso.Oliveira@synopsys.com> * Add gen:go to CI regression. Signed-off-by: Afonso Oliveira <Afonso.Oliveira@synopsys.com> * Add gen:go to local regression test. Signed-off-by: Afonso Oliveira <Afonso.Oliveira@synopsys.com> --------- Signed-off-by: Afonso Oliveira <Afonso.Oliveira@synopsys.com> Co-authored-by: Your Name <your.email@example.com>
fixes #520 Co-authored-by: Derek Hower <134728312+dhower-qc@users.noreply.github.com>
Mentored-by: Derek Hower <134728312+dhower-qc@users.noreply.github.com> Mentored-by: Paul A. Clarke <pclarke@ventanamicro.com> Signed-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com>
Mentored-by: Derek Hower <134728312+dhower-qc@users.noreply.github.com> Mentored-by: Paul A. Clarke <pclarke@ventanamicro.com> Signed-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com>
Mentored-by: Derek Hower <134728312+dhower-qc@users.noreply.github.com> Mentored-by: Paul A. Clarke <pclarke@ventanamicro.com> Signed-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com>
Also ran `pre-commit run --all-files` and new version of clang-fmt changed one file
…#549) * arch/inst: Add SPDX snippet to YAML files containing sail() function. Mentored-by: Derek Hower <134728312+dhower-qc@users.noreply.github.com> Mentored-by: Paul A. Clarke <pclarke@ventanamicro.com> Signed-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com> * arch/inst: Update the SPDX license to point to SPDX-FileCopyrightText. Mentored-by: Derek Hower <134728312+dhower-qc@users.noreply.github.com> Mentored-by: Paul A. Clarke <pclarke@ventanamicro.com> Signed-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com> * arch/inst: fix pre-commit EOF newline complaints Mentored-by: Derek Hower <134728312+dhower-qc@users.noreply.github.com> Mentored-by: Paul A. Clarke <pclarke@ventanamicro.com> Signed-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com> --------- Signed-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com> Co-authored-by: Derek Hower <134728312+dhower-qc@users.noreply.github.com>
* Xqci(Xqcibm,Xqcicli,Xqcilo) extensions: fix sext() IDL function calls for several instructions: qc.e.lb,qc.e.lh,qc.ext,qc.extd,qc.extdpr,qc.extdprh,qc.extdr,qc.lieq Signed-off-by: Albert Yosher <quic_ayosher@quicinc.com> * Xqci (Xqcibm) extension: Fix IDL code and description increasing shift to 6 bit for all dual-register bitfield extraction instructions, where shift and width of bitfield are in register Signed-off-by: Albert Yosher <quic_ayosher@quicinc.com> * Xqci (Xqcia) extension: fix wrong mantissa bit selection for qc.norm, qc.normu and qc.normeu instructions Signed-off-by: Albert Yosher <quic_ayosher@quicinc.com> * Xqci (Xqcia) extension: fix wrong exponent calculation for qc.normeu instructions Signed-off-by: Albert Yosher <quic_ayosher@quicinc.com> * Xqci (Xqcilsm) extension: Fix IDL code and description of qc.setwm instruction to state that number of words written 0..31. Signed-off-by: Albert Yosher <quic_ayosher@quicinc.com> * Xqci (Xqciint) extension: Fix IDL code for Smdbltrp and Smrnmi spec compatibility for qc.c.mret and qc.c.mnret instructions Signed-off-by: Albert Yosher <quic_ayosher@quicinc.com> --------- Signed-off-by: Albert Yosher <quic_ayosher@quicinc.com>
* task: sort apt pkgs * fix: add missing pkgs to docker container
Nightly builds are failing because the 'test:nightly' task tries to call 'regress'. It should be 'test:regress'. Signed-off-by: Derek Hower <134728312+dhower-qc@users.noreply.github.com>
* Fix mret and mnret instructions to support correctly Smdbltrp (MDT bit) and MPRV bit Before his fix IDL code reset mstatus.MPRV bit only in case if S mode is implemented for both mret and mnret. This seems wrong, since spec states that MPRV should be reset by both mret and mnret for case when mode processor is returning is different from Machine mode (2b'11). As well, Smdbltrp spec requires that such case (returning to non-machine mode), the mnret instruction should reset MDT bit. According to the spec mnret instruction should set mnstatus.NMIE=1. Also, mnret should use mnstatus.MNPP bit field for previous mode storage. Signed-off-by: Albert Yosher <quic_ayosher@quicinc.com> * MNRET instruction: improving long name and description to match Smrnmi and Smdbltrp extensions documentation Signed-off-by: Albert Yosher <quic_ayosher@quicinc.com> --------- Signed-off-by: Albert Yosher <quic_ayosher@quicinc.com> Co-authored-by: Derek Hower <134728312+dhower-qc@users.noreply.github.com>
Signed-off-by: Derek Hower <134728312+dhower-qc@users.noreply.github.com> Co-authored-by: Derek Hower <134728312+dhower-qc@users.noreply.github.com>
…518) * Add synopses and descriptions for Zacas instructions * Add synopses and descriptions for Zacas instructions * Add synopses and descriptions for Zacas instruction * Add synopses and descriptions for Zacas instructions. * Add synopses and descriptions for Zacas instructions --------- Co-authored-by: Derek Hower <134728312+dhower-qc@users.noreply.github.com>
* Added XLEN as a length type for CSRs * More updates to Ruby CSR object + description for CSR schema * More fixes for Ruby CSR object * More fixes to Ruby CSR object --------- Signed-off-by: Katherine Hsu <67767297+neverlandiz@users.noreply.github.com>
* Adding phase 1 index Signed-off-by: Afonso Oliveira <Afonso.Oliveira@synopsys.com> * Adding phase 1 index to ./do Signed-off-by: Afonso Oliveira <Afonso.Oliveira@synopsys.com> * Adding phase 1 index: instructions_index object Signed-off-by: Afonso Oliveira <Afonso.Oliveira@synopsys.com> * Generate appendix through UDB. * Changes names and paths file structure Signed-off-by: Afonso Oliveira <Afonso.Oliveira@synopsys.com> * Update template to ensure correct output. Signed-off-by: Afonso Oliveira <Afonso.Oliveira@synopsys.com> * Remove outdated file. Signed-off-by: Afonso Oliveira <Afonso.Oliveira@synopsys.com> * Add appendix generation to regression test. Signed-off-by: Afonso Oliveira <Afonso.Oliveira@synopsys.com> * Set up hexa numbers to input wavedrom diagram. Makes the 0s and 1s be in each own cell Signed-off-by: Afonso Oliveira <Afonso.Oliveira@synopsys.com> --------- Signed-off-by: Afonso Oliveira <Afonso.Oliveira@synopsys.com> Co-authored-by: Derek Hower <134728312+dhower-qc@users.noreply.github.com>
This commit adds support for the Zcmop extension by defining the 16-bit compressed C.MOP.n instructions. These instructions use a fixed encoding pattern with a variable field (mop_n_field) to select one of eight instructions (for odd n values from 1 to 15). By default, they do not write to any registers, which allows them to safely act as no-ops when the extension is not active. This change lays the foundation for future extensions that may redefine these instructions. Co-authored-by: Afonso Oliveira <Afonso.Oliveira@synopsys.com>
#542) * Add Zilsd extension YAML Add support for the Zilsd extension, which introduces load/store pair instructions for RV32. These instructions allow efficient 64-bit memory operations using register pairs. Ensure proper alignment rules, trap handling, and atomicity requirements. Improve memory efficiency and reduce instruction count for doubleword operations. * add Zilsd instructions
* schema: add array form of description Adds an array form of "description" fields that enables tagged statements. In this first cut, statements can be tagged as: - normative or non-normative. - conditional, using an IDL function to evaluate the condition * schema: add id field to array form of descriptions IDs should never change, even if the underlying text changes
* Rename Sm#XLEN parameter -> Sm#MXLEN * fix: missing base in hpmcounterNh * fix: use MXLEN in Zilsd instructions
done with `pre-commit autoupdate` also ran `pre-commit run --all-files` to make sure everything still passes and no changes
* Update H.yaml Signed-off-by: M Abdullah <2022ee19@gmail.com> * Updated H.yaml --------- Signed-off-by: M Abdullah <2022ee19@gmail.com> Co-authored-by: root <2022e19@gmail.com>
…n to match Smdbltrp behaviour (#618) Signed-off-by: Albert Yosher <quic_ayosher@quicinc.com>
Preparing for developing a custom IDE for UDB with Eclipse.
Fix missing $source metadata in YAML resolution pipeline Resolves "No $source" errors for all 371 CSR files Fixes infrastructure failures in regress-smoke tests Ensures proper source file tracking for database objects Maintains architectural separation between Python resolution and Ruby consumption first mentioned on #936 & #933 Fixes #953 @ThinkOpenly @dhower-qc @AFOliveira @adingank-qualcomm --------- Signed-off-by: Sukuna0007Abhi <appsonly310@gmail.com> Signed-off-by: GitHub <noreply@github.com> Co-authored-by: Derek Hower <134728312+dhower-qc@users.noreply.github.com>
Fixes (hopefully, I don't know how to test locally) two minor bugs from #964. Also restores the pages deployment by making the pages workflow run after the deployment workflow.
This PR updates incorrect `$schema` paths across multiple YAML files in the specs, ensuring they correctly reference their respective schema files. Several files had outdated or broken paths that caused schema validation to fail.
Fix mathematical notation rendering in documentation (Issue #78) Hey team! This fixes the issue where mathematical expressions were showing up as ugly raw LaTeX code instead of properly formatted math. Fixes #78 What was broken Mathematical expressions like \({-}2^{31}{-}2^{11}\) and \(2^{31}{-}2^{11}{-}1\) in the RV64 documentation were displaying as literal text instead of nice mathematical notation. Not exactly professional-looking for a technical spec! The rabbit hole I went down(#932) Initially I tried adding custom MathJax scripts and other complicated workarounds. But @AFOlivera set me straight with his "test before PR" methodology - turns out I was overengineering the solution. What I actually found The real issue was kind of sneaky: our build system has both Ruby and Node.js components, and when I added 'asciidoctor-mathjax' to the Antora config, the Ruby side was trying to install it as a Ruby gem (which doesn't exist) instead of letting Node.js handle it as the npm package it actually is. The fix Used ERB interpolation to "hide" the extension name from Ruby's gem scanner: The asciidoctor-mathjax@0.0.5 package was already sitting in our node_modules waiting to be used - I just needed to reference it properly. What this changes Mathematical expressions will render as actual formatted equations No more raw LaTeX code cluttering up the documentation Uses existing project infrastructure (no new dependencies) Cleaner, more professional-looking technical docs Thanks to @AFOlivera. forgot to mention : There's an unrelated sorbet-static platform issue in my build environment, but that's separate from the math rendering problem you identified. That's why I can't perfectly test that pdf part. Ready for Review. @ThinkOpenly @AFOliveira @dhower-qc --------- Signed-off-by: Sukuna0007Abhi <appsonly310@gmail.com>
## Summary Fixes issue #927 where single extension definitions were showing unnecessary bullet points in the HTML documentation's "Defining Extension" section. ## Problem - Single extensions like `definedBy: Sm` were displaying as `• Sm, version >= 1.11.0` with unwanted bullet points - This made the documentation look cluttered for simple cases where only one extension is involved - Multiple extensions correctly needed bullets, but single ones should appear clean ## Solution - Modified `to_asciidoc` method in `req_expression.rb` to detect simple single extensions at root level - Added `is_simple_single_extension?()` helper to identify when bullets aren't needed - Added `to_asciidoc_no_bullet()` method for clean formatting of single extensions - Preserved existing bullet behavior for complex multi-extension conditions (allOf, anyOf, etc.) ## Testing - Single extensions now display cleanly: `Sm, version >= 1.11.0` - Multiple extensions maintain proper structure with bullets - No regression in complex extension requirement formatting ## Impact - Improves readability of HTML documentation for CSRs with single defining extensions - Maintains backward compatibility for all existing complex extension definitions Ready for Review @ThinkOpenly @dhower-qc Fixes #927 --------- Signed-off-by: Sukuna0007Abhi <appsonly310@gmail.com> Signed-off-by: GitHub <noreply@github.com>
Added testIdl project with three examples of adding CSRs. The intent is to help the students who will be working on the Eclipse-based custom IDE in the CS Clinic at Harvey Mudd College.
With this PR, commit messages will no longer be checked for compliance to conventional commits. However, PR titles *will be checked*.
Signed-off-by: Derek Hower <134728312+dhower-qc@users.noreply.github.com>
) Fixes #831. Currently the instructions and CSR tables in ISA explorer take very long to load or do not load properly. By loading large datasets in chunks, the tables can be rendered quickly on page load. This can be done using the `addData` method provided by tabulator to populate the table after its been built. Scrolling Instructions table currently: https://github.com/user-attachments/assets/3d62860e-4551-48a9-9985-04cd11066f25 Scrolling Instructions table with fix applied: https://github.com/user-attachments/assets/5ac7d695-983c-43f0-ac57-5a94dc65493b Requesting review @james-ball-qualcomm
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.18.8 to 1.18.9. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/sparklemotion/nokogiri/releases">nokogiri's releases</a>.</em></p> <blockquote> <h2>v1.18.9 / 2025-07-20</h2> <h3>Security</h3> <ul> <li>[CRuby] Applied upstream libxml2 patches to address CVE-2025-6021, CVE-2025-6170, CVE-2025-49794, CVE-2025-49795, and CVE-2025-49796. See <a href="https://github.com/sparklemotion/nokogiri/security/advisories/GHSA-353f-x4gh-cqq8">GHSA-353f-x4gh-cqq8</a> for more information.</li> </ul> <!-- raw HTML omitted --> <pre><code>5bcfdf7aa8d1056a7ad5e52e1adffc64ef53d12d0724fbc6f458a3af1a4b9e32 nokogiri-1.18.9-aarch64-linux-gnu.gem 55e9e6ca46c4ad1715e313f407d8481d15be1e3b65d9f8e52ba1c124d01676a7 nokogiri-1.18.9-aarch64-linux-musl.gem eea3f1f06463ff6309d3ff5b88033c4948d0da1ab3cc0a3a24f63c4d4a763979 nokogiri-1.18.9-arm64-darwin.gem fe611ae65880e445a9c0f650d52327db239f3488626df4173c05beafd161d46e nokogiri-1.18.9-arm-linux-gnu.gem 935605e14c0ba17da18d203922440bf6c0676c602659278d855d4622d756a324 nokogiri-1.18.9-arm-linux-musl.gem ac5a7d93fd0e3cef388800b037407890882413feccca79eb0272a2715a82fa33 nokogiri-1.18.9.gem 1fe5b7aa4a054eda689a969bb4e03999960a6ea806582d327207d687168bceb5 nokogiri-1.18.9-java.gem 6b4fc1523aa0370c78653e38c94cb50e7f3ab786425de66ba7ad24222c1164a3 nokogiri-1.18.9-x64-mingw-ucrt.gem e0d2deb03d3d7af8016e8c9df5ff4a7d692159cefb135cbb6a4109f265652348 nokogiri-1.18.9-x86_64-darwin.gem b52f5defedc53d14f71eeaaf990da66b077e1918a2e13088b6a96d0230f44360 nokogiri-1.18.9-x86_64-linux-gnu.gem e69359d6240c17e64cc9f43970d54f13bfc7b8cc516b819228f687e953425e69 nokogiri-1.18.9-x86_64-linux-musl.gem </code></pre> <!-- raw HTML omitted --> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md">nokogiri's changelog</a>.</em></p> <blockquote> <h2>v1.18.9 / 2025-07-20</h2> <h3>Security</h3> <ul> <li>[CRuby] Applied upstream libxml2 patches to address CVE-2025-6021, CVE-2025-6170, CVE-2025-49794, CVE-2025-49795, and CVE-2025-49796. See <a href="https://github.com/sparklemotion/nokogiri/security/advisories/GHSA-353f-x4gh-cqq8">GHSA-353f-x4gh-cqq8</a> for more information.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/sparklemotion/nokogiri/commit/1dcd8ce30365ebd4620a3b823bf806b127eeefc3"><code>1dcd8ce</code></a> version bump to v1.18.9</li> <li><a href="https://github.com/sparklemotion/nokogiri/commit/a05d2b44b930072af70dad12bddbac67f36c6f90"><code>a05d2b4</code></a> Apply upstream patches to address multiple vulnerabilities (<a href="https://redirect.github.com/sparklemotion/nokogiri/issues/3526">#3526</a>)</li> <li><a href="https://github.com/sparklemotion/nokogiri/commit/947a55e87edff3c6d76ffd81f07da728e67c9b82"><code>947a55e</code></a> Apply upstream patches to address multiple vulnerabilities</li> <li>See full diff in <a href="https://github.com/sparklemotion/nokogiri/compare/v1.18.8...v1.18.9">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/riscv-software-src/riscv-unified-db/network/alerts). </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Derek Hower <134728312+dhower-qc@users.noreply.github.com>
Fixes problem where backticks showed up in red in PDFs: <img width="156" height="23" alt="image" src="https://github.com/user-attachments/assets/5c54e238-5357-42dc-aa35-64bb57b9489a" /> now looks like: <img width="163" height="27" alt="image" src="https://github.com/user-attachments/assets/a92626de-6de1-4df1-bca1-e8f0ae3fef2f" /> --------- Signed-off-by: Derek Hower <134728312+dhower-qc@users.noreply.github.com> Co-authored-by: Paul Clarke <pclarke@ventanamicro.com>
The mstatus.VS field was incorrectly written with the value of the FS field from a CSR write. Update it to use the VS field as expected. Signed-off-by: Jordan Carlin <jordanmcarlin@gmail.com>
Added YAML specification for Ssdbltrp extension version 1.0.0. Just definition part :) Related to issue #212 Signed-off-by: Sukuna0007Abhi <appsonly310@gmail.com>
Makes it look like this (template stuff will be replaced in deploy flow): <img width="1385" height="805" alt="image" src="https://github.com/user-attachments/assets/4e5d973a-6b20-4c75-a352-63aa3fdd44de" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebasing the vector branch to main branch to get all the latest updates