feat: smepmp from #652 #1153
Open
feat: smepmp from #652 #1153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cfg and mseccfgh # Conflicts: # spec/std/isa/ext/Smepmp.yaml
# Conflicts: # spec/std/isa/ext/Smepmp.yaml
sudo-apt-abdullah
requested review from
ThinkOpenly and
dhower-qc
as code owners
ThinkOpenly
reviewed
Oct 2, 2025
ThinkOpenly
reviewed
Oct 2, 2025
ThinkOpenly
reviewed
Oct 2, 2025
ThinkOpenly
reviewed
Oct 2, 2025
ThinkOpenly
reviewed
Oct 2, 2025
ThinkOpenly
reviewed
Oct 2, 2025
Collaborator
|
Not sure why the CI is failing? Something to do with the parameter definitions, perhaps? |
ThinkOpenly
requested changes
Oct 2, 2025
sudo-apt-abdullah
force-pushed
the
Smepmp_work
branch
from
90d679b to
881c2b4
Compare
sudo-apt-abdullah
force-pushed
the
Smepmp_work
branch
from
272e7ce to
920efeb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1153 +/- ##
=======================================
Coverage 46.05% 46.05%
=======================================
Files 11 11
Lines 4942 4942
Branches 1345 1345
=======================================
Hits 2276 2276
Misses 2666 2666
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ThinkOpenly
requested changes
Oct 6, 2025
ThinkOpenly
requested changes
Nov 12, 2025
Collaborator
ThinkOpenly
left a comment
ThinkOpenly
left a comment
There was a problem hiding this comment.
Given that mseccfg is "an optional" register, we'll need a boolean parameter for whether it is indeed supported.
We'll also need to force that parameter to true for the handful of extensions that depend on it's existence.
| priv_mode: M | ||
| length: 64 | ||
| description: Machine Security Configuration | ||
| length: MXLEN |
Collaborator
There was a problem hiding this comment.
mseccfg is an optional 64-bit read/write register
Suggested change
| length: MXLEN | |
| length: 64 |
Comment on lines
15
to
+17
| definedBy: | ||
| name: Sm | ||
| version: ">= 1.12" | ||
| fields: {} | ||
| name: Smepmp | ||
| version: ~> 1.0.0 |
Collaborator
There was a problem hiding this comment.
Suggested change
| definedBy: | |
| name: Sm | |
| version: ">= 1.12" | |
| fields: {} | |
| name: Smepmp | |
| version: ~> 1.0.0 | |
| definedBy: | |
| name: Sm | |
| version: ">= 1.12" |
Comment on lines
+18
to
+19
| name: Smepmp | ||
| version: ~> 1.0.0 |
Collaborator
There was a problem hiding this comment.
Suggested change
| name: Smepmp | |
| version: ~> 1.0.0 | |
| name: Sm | |
| version: ">= 1.12" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #219