Skip to content

Conversation

@qwersem
Copy link

@qwersem qwersem commented Oct 24, 2025

The build script leaves multiple containers in a host environment. This update adds an --rm option to remove a Docker container after a command is executed.

Steps to reproduce the issue

$ git clone https://github.com/riscv-software-src/riscv-unified-db.git
$ cd riscv-unified-db
$ export DOCKER=1
$ ./do test:smoke
Fetching gem metadata from https://rubygems.org/......
$ docker container ls -a
Emulate Docker CLI using podman. Create /etc/containers/nodocker to quiet msg.
CONTAINER ID  IMAGE                        COMMAND               CREATED         STATUS                     PORTS       NAMES
b49df1bcbc2c  docker.io/riscvintl/udb:0.9  bundle config set...  11 minutes ago  Exited (0) 11 minutes ago              quirky_swirles
28b906b730bf  docker.io/riscvintl/udb:0.9  bundle config set...  11 minutes ago  Exited (0) 11 minutes ago              amazing_goldberg
e189ebdd5e27  docker.io/riscvintl/udb:0.9  bundle config set...  11 minutes ago  Exited (0) 11 minutes ago              optimistic_kowalevski
9c34939c2770  docker.io/riscvintl/udb:0.9  bundle install        11 minutes ago  Exited (0) 10 minutes ago              magical_murdock
c118fdd21182  docker.io/riscvintl/udb:0.9  /usr/bin/python3 ...  10 minutes ago  Exited (0) 10 minutes ago              intelligent_margulis
bad9ac0863cf  docker.io/riscvintl/udb:0.9  /home/q/workspace...  10 minutes ago  Exited (0) 10 minutes ago              blissful_keller
c53716cb242a  docker.io/riscvintl/udb:0.9  npm i                 10 minutes ago  Exited (0) 10 minutes ago              cranky_colden
4eb3b575a6df  docker.io/riscvintl/udb:0.9  bundle exec --gem...  10 minutes ago  Exited (0) 5 minutes ago               nervous_germain

The build script leaves multiple containers in a host environment. This update adds an `--rm` option to remove a Docker container after a command is executed.

Signed-off-by: Evgeny Semenov <semenov@synopsys.com>
@dhower-qc
Copy link
Collaborator

I'm not very familiar with Docker. Does this have any performance impact on subsequent runs? (I think it probably doesn't, but want to check)

@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.05%. Comparing base (3d9129d) to head (d5698b9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1197   +/-   ##
=======================================
  Coverage   46.05%   46.05%           
=======================================
  Files          11       11           
  Lines        4942     4942           
  Branches     1345     1345           
=======================================
  Hits         2276     2276           
  Misses       2666     2666           
Flag Coverage Δ
idlc 46.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ThinkOpenly
Copy link
Collaborator

I'm going to show my ignorance. Are the docker run commands intended to modify an existing container? My reading of the documentation (admittedly, for podman) shows the "run" subcommand running in a new container. I presume that's why all of these containers are being left around.

Should we be using docker exec instead of docker run?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants