Skip to content

Conversation

@henrikg-qc
Copy link
Collaborator

  • RV64 tests for the ISS
    Added rv64-riscv-tests configuration
    Updated test:riscv-tests target with ability to build and test RV64 configuration
  • Corrected many instruction implementations to handle 64bit mode
  • Corrected the page walker and address translation
  • Added rv64 riscv-tests to the regression

@henrikg-qc henrikg-qc self-assigned this Nov 21, 2025
@henrikg-qc henrikg-qc added the enhancement New feature or request label Nov 21, 2025
@henrikg-qc henrikg-qc changed the title Feat: Adding RV64 riscv-tests suite in build and regression feat: adding RV64 riscv-tests suite in build and regression Nov 21, 2025
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.05%. Comparing base (7e57cf3) to head (94d2f1a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1259   +/-   ##
=======================================
  Coverage   46.05%   46.05%           
=======================================
  Files          11       11           
  Lines        4942     4942           
  Branches     1345     1345           
=======================================
  Hits         2276     2276           
  Misses       2666     2666           
Flag Coverage Δ
idlc 46.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@henrikg-qc henrikg-qc enabled auto-merge November 25, 2025 16:15
@henrikg-qc
Copy link
Collaborator Author

henrikg-qc commented Nov 25, 2025

@ThinkOpenly
I replaced regress-riscv-tests with 2 new tests in the regression. It now seems to wait for the old test that is not ran anymore.
Do you have an idea how to get around this?

@jordancarlin
Copy link
Contributor

@ThinkOpenly I replaced regress-riscv-tests with 2 new tests in the regression. It now seems to wait for the old test that is not ran anymore. Do you have an idea how to get around this?

Most likely, the issue is the list of required actions set in the GitHub repo settings. The exact names of the required actions need to be listed there. The way we got around this for sail-riscv is to have a dummy action that just depends on all of the previous actions, and then only require that action in the actual repo settings. Then, to change the required actions, anyone can modify the list of dependencies for that one required job. See https://github.com/riscv/sail-riscv/blob/659f5181d7991c957591b3e48e62807ae475b24b/.github/workflows/ci.yml#L105-L113.

@henrikg-qc
Copy link
Collaborator Author

@ThinkOpenly I replaced regress-riscv-tests with 2 new tests in the regression. It now seems to wait for the old test that is not ran anymore. Do you have an idea how to get around this?

Most likely, the issue is the list of required actions set in the GitHub repo settings. The exact names of the required actions need to be listed there. The way we got around this for sail-riscv is to have a dummy action that just depends on all of the previous actions, and then only require that action in the actual repo settings. Then, to change the required actions, anyone can modify the list of dependencies for that one required job. See https://github.com/riscv/sail-riscv/blob/659f5181d7991c957591b3e48e62807ae475b24b/.github/workflows/ci.yml#L105-L113.

Thanks, for this I can rename the 32 bit test regression to match the test name I replaced as they were the same, just slightly different way to call the tests using rake. I'm hoping this will get around it for now.

@henrikg-qc henrikg-qc added this pull request to the merge queue Nov 26, 2025
Merged via the queue into main with commit 139625a Nov 26, 2025
59 checks passed
@henrikg-qc henrikg-qc deleted the rv64tests branch November 26, 2025 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants