-
Notifications
You must be signed in to change notification settings - Fork 78
feat: consolidate all YAML conditionals #891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dhower-qc
wants to merge
45
commits into
main
Choose a base branch
from
param_dep
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
bc76954
feat(idl): add constraints to IDL
dhower-qc 60f2054
feat: add mock spec to udb gem for testing, add Condition classes
dhower-qc 6928ad8
docs: document schema conditions and idl implications
dhower-qc 19c9d58
refactor: move parameters into their own YAML files
dhower-qc 345b441
feat: wip
dhower-qc 0db0e7c
feat: wip
dhower-qc 2d5fb7f
feat: wip
dhower-qc e5a1756
Merge remote-tracking branch 'origin/main' into param_dep
dhower-qc 3bad309
fix: merge errors
dhower-qc e0fa497
wip
dhower-qc 688ae1f
wip
dhower-qc e8f0cb5
add regress job dependency
dhower-qc a0efba3
Merge remote-tracking branch 'origin/main' into param_dep
dhower-qc 8cc68a6
Fix path in regression for udb unit tests
dhower-qc 728a407
wip
dhower-qc 511534d
wip
dhower-qc 2146664
wip
dhower-qc c83c9bd
wip
dhower-qc 00f22de
wip
dhower-qc 5383f39
wip
dhower-qc 452c776
wip
dhower-qc ac82312
wip
dhower-qc 6b3ed6c
wip
dhower-qc ac2fc62
wip
dhower-qc 2f931cb
wip
dhower-qc ca34bc4
wip
dhower-qc 044a455
wip
dhower-qc 9f8d8cc
Merge remote-tracking branch 'origin/main' into param_dep
dhower-qc 0d4ff5e
wip
dhower-qc bccec45
wip
dhower-qc bcfe7e2
wip
dhower-qc 51eee36
wip
dhower-qc f0192da
Merge remote-tracking branch 'origin/main' into param_dep
dhower-qc ff4a76d
Merge remote-tracking branch 'origin/main' into param_dep
dhower-qc 8d8d182
wip
dhower-qc dc67562
wip
dhower-qc 3d191bc
wip
dhower-qc b0be0de
wip
dhower-qc 0b34ef5
qip
dhower-qc 9c2b695
wip
dhower-qc 36d205a
wip
dhower-qc 711b06e
wip
dhower-qc dcf6d37
wip
dhower-qc 500c2ca
wip
dhower-qc bed5d6f
wip
dhower-qc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,7 @@ | |
| .stamps | ||
| .venv | ||
| .asciidoctor | ||
| .cache | ||
| .vscode/* | ||
| !.vscode/launch.json | ||
| !.vscode/extensions.json | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should an issue be opened in that upstream repo for this problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[I know this is not terribly important... I am testing the use of the
ghcommand to submit comments on the code. ;-) ]