-
Notifications
You must be signed in to change notification settings - Fork 1
feat: add auth_oauth
#132
base: main
Are you sure you want to change the base?
feat: add auth_oauth
#132
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @Blckbrry-Pi and the rest of your teammates on |
auth_username_pasword moduleauth_username_pasword module
7a771d2 to
a84215f
Compare
461712a to
2873938
Compare
auth_username_pasword moduleauth_username_pasword, auth_email, and auth_oauth
| @@ -0,0 +1,11 @@ | |||
| export interface Config { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's rename this to customProviders and add pre-configured blocks for google, facebook, etc.
see the repo i sent an while back for reference on pre-made configs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do. This will require some reworking however, and IMO that functionality should be provided by a google or facebook module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok cool let's get the interface stable then by just renaming this to "customProviders" and add presets later
85377b5 to
5520319
Compare
a84215f to
564ae91
Compare
5520319 to
3b421b9
Compare
564ae91 to
1b445c7
Compare
3b421b9 to
ea83953
Compare
1b445c7 to
91cb526
Compare
5b70e06 to
ef45e3e
Compare
| @@ -0,0 +1,11 @@ | |||
| export interface Config { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok cool let's get the interface stable then by just renaming this to "customProviders" and add presets later
| IDENTITY_INFO_PASSWORDLESS, | ||
| } from "./provider.ts"; | ||
|
|
||
| export async function ensureNotAssociated( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
repost: this is very very expensive, it does at least 3 round trips to the database before doing anything else in the request. we should expose a batch api on identities module for this.
to answer the q: it should be very easy to pass multiple identity types to the query so it can be configurable. but also, that won't be a breaking change, so go for the simpler option.
| return output; | ||
| } | ||
|
|
||
| export function generateRandomCodeSecure( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neat. we need ot refactor tokens itself to use this function since it still depends on an insecure version.
91cb526 to
7677207
Compare
eac22ac to
53d1543
Compare
7677207 to
392079a
Compare
53d1543 to
709f613
Compare
392079a to
b504d85
Compare
32352b5 to
658d5a4
Compare
b504d85 to
8358d72
Compare
b85d1e6 to
64571da
Compare
auth_username_pasword, auth_email, and auth_oauthauth_oauth
515a6d2 to
0f9152f
Compare
64571da to
c724d76
Compare
c724d76 to
7767658
Compare
7767658 to
c9ea5ef
Compare

No description provided.