Skip to content

fix(rivetkit): don't throw error if websocket is not open, causing realtime to break after a connection disconnects #3316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(rivetkit): don't throw error if websocket is not open, causing realtime to break after a connection disconnects #3316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion rivetkit-typescript/packages/rivetkit/src/actor/conn-drivers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,19 @@ export interface ConnDriver<State> {
const WEBSOCKET_DRIVER: ConnDriver<ConnDriverWebSocketState> = {
sendMessage: (
actor: AnyActorInstance,
_conn: AnyConn,
conn: AnyConn,
state: ConnDriverWebSocketState,
message: CachedSerializer<protocol.ToClient>,
) => {
if (state.websocket.readyState !== ConnReadyState.OPEN) {
actor.rLog.warn({
msg: "attempting to send message to closed websocket, this is likely a bug in RivetKit",
connId: conn.id,
wsReadyState: state.websocket.readyState,
});
return;
}

const serialized = message.serialize(state.encoding);

actor.rLog.debug({
Expand Down
Loading