Skip to content

fix(runner): fix http requests not returning 503 when actor removed #3322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(runner): fix http requests not returning 503 when actor removed #3322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion engine/sdks/typescript/runner/src/tunnel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,12 @@ export class Tunnel {
msg: "ignoring request for unknown actor",
actorId,
});
return new Response("Actor not found", { status: 404 });

// NOTE: This is a special response that will cause Guard to retry the request
//
// See should_retry_request_inner
// https://github.com/rivet-dev/rivet/blob/222dae87e3efccaffa2b503de40ecf8afd4e31eb/engine/packages/guard-core/src/proxy_service.rs#L2458
return new Response("Actor not found", { status: 503, headers: { "x-rivet-error": "runner.actor_not_found" } });
}

const fetchHandler = this.#runner.config.fetch(
Expand Down
Loading