Skip to content

fix(rivetkit): fix initial hibernation state always being overridden with msgIndex of -1 #3389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(rivetkit): fix initial hibernation state always being overridden with msgIndex of -1 #3389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 27 additions & 6 deletions rivetkit-typescript/packages/rivetkit/src/drivers/engine/actor-driver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,11 +181,20 @@ export class EngineActorDriver implements ActorDriver {
// Determine configuration for new WS
let hibernationConfig: HibernationConfig;
if (existingWs) {
logger().debug({
msg: "found existing hibernatable websocket",
requestId: idToStr(requestId),
lastMsgIndex: existingWs.msgIndex,
});
hibernationConfig = {
enabled: true,
lastMsgIndex: Number(existingWs.msgIndex),
};
} else {
logger().debug({
msg: "no existing hibernatable websocket found",
requestId: idToStr(requestId),
});
if (path === PATH_CONNECT_WEBSOCKET) {
hibernationConfig = {
enabled: true,
Expand Down Expand Up @@ -251,12 +260,24 @@ export class EngineActorDriver implements ActorDriver {
}
}

// Save hibernatable WebSocket
handler.actor[PERSIST_SYMBOL].hibernatableWebSocket.push({
requestId,
lastSeenTimestamp: BigInt(Date.now()),
msgIndex: -1n,
});
// Save or update hibernatable WebSocket
if (existingWs) {
logger().debug({
msg: "updated existing hibernatable websocket timestamp",
requestId: idToStr(requestId),
});
existingWs.lastSeenTimestamp = BigInt(Date.now());
} else {
logger().debug({
msg: "created new hibernatable websocket entry",
requestId: idToStr(requestId),
});
handler.actor[PERSIST_SYMBOL].hibernatableWebSocket.push({
requestId,
lastSeenTimestamp: BigInt(Date.now()),
msgIndex: -1n,
});
}

return hibernationConfig;
},
Expand Down
Loading