Skip to content

Conversation

@rkotze
Copy link
Owner

@rkotze rkotze commented Jul 12, 2025

Enable user to commit with different git trailers like Signed-off-by:

Issue URL: #121

Related to: rkotze/git-mob-vs-code#455

What is the new behaviour?

What was the behaviour?

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Updated the CHANGELOG.md to capture my changes
  • Build (npm run build) was successfully run locally
  • All tests and linting (npm run checks) has passed locally
  • I kept my pull requests small so it can be reviewed easier

Pull request type

Please check the type of change your PR introduces:

  • Feature

Does this introduce a breaking change?

  • Yes
  • No

Other information

@rkotze rkotze self-assigned this Jul 12, 2025
@rkotze rkotze added the enhancement New feature or request label Jul 12, 2025
rkotze added 8 commits July 13, 2025 15:31
Each author can have their own trailer type.
It still makes sense as an api as it will get all trailers of contributing authors.
- Implemented setSelectedAuthors to select authors with trailers.
- Updated tests to mock and validate new functionality.
- Enhanced author mocks to support trailers in author creation.
- Update test script to include coverage and verbosity
- Modify Author class format method to include a colon in trailer output
- Refactor setSelectedAuthors to accept an array of key-trailer pairs
- Adjust messageFormatter to remove trailing colons from trailer enums
- Add new tests for setting signed-off-by trailers via CLI
- Clean up unused imports in test environment setup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants