Client certificate support in clj-apache-http #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… changes to code.
Conflicts: tests/async_client.clj
requests through one client.
…operly. Version is at 1.0.8.
…and async clients.
the SSL context was initialized for the async client.
…. Callbacks only deal with the CountdownLatch if it exists.
…ure 1.3 use. Changes: - Replaced use of clojure.contrib.json to clojure.data.json in new data.json module - Replaced use of clojure.contrib.string/chomp with clojure.string/trim-newline - Replaced use of clojure.contrib.io/slurp* with clojure.core/slurp - Replaced use of clojure.contrib.io/reader wtih clojure.java.io/reader - Replaced use of clojure.contrib.java-utils/file with clojure.java.io/file - Replaced use of clojure.contrib.base64 with Base64 in Apache commons-codec (already used transitively)
Remove dependency on clojure-contrib to make this friendlier for Clojure 1.3 use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I forked the clj-apache-http project because I needed to add support for HTTPS connections that use x509 client certificates.
This code is working. If you want to pull it back in to clj-apache-http, please do. Since my experience with clojure is limited, you may want to take some time to review the code. One issue that I know exists is that you have to run lein compile on NaiveTrustManager.clj and PermissiveHostnameVerifier.clj before you can use them. That's not really standard practice.
Anyway, if this is helpful, please feel free to add it to your project.
Thanks.
Andrew Diamond
Hotelicopter.com