Skip to content

fix(android): Add long click listener support for point annotations #3847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Elter71
Copy link
Contributor

@Elter71 Elter71 commented Apr 30, 2025

Description

Fixes #3715

The issue appeared after a change in the Mapbox Android library in version v10.18.4, specifically in this commit. After I added OnPointAnnotationLongClickListener to RNMBXPointAnnotationCoordinator, everything started working fine. I’m not sure why this change fixes the issue, so I’ve marked the PR as a draft.

Checklist

  • I've read CONTRIBUTING.md
  • I updated the doc/other generated code with running yarn generate in the root folder
  • [] I have tested the new feature on /example app.
    • In V11 mode/ios
    • In New Architecture mode/ios
    • In V11 mode/android
    • In New Architecture mode/android
  • I added/updated a sample - if a new feature was implemented (/example)

@Elter71 Elter71 had a problem deploying to CI with Mapbox Tokens April 30, 2025 15:15 — with GitHub Actions Failure
@Elter71 Elter71 had a problem deploying to CI with Mapbox Tokens April 30, 2025 15:15 — with GitHub Actions Failure
@Elter71 Elter71 had a problem deploying to CI with Mapbox Tokens April 30, 2025 15:15 — with GitHub Actions Failure
@Elter71 Elter71 had a problem deploying to CI with Mapbox Tokens April 30, 2025 15:15 — with GitHub Actions Failure
@Elter71 Elter71 had a problem deploying to CI with Mapbox Tokens April 30, 2025 15:15 — with GitHub Actions Failure
@Elter71 Elter71 had a problem deploying to CI with Mapbox Tokens April 30, 2025 15:15 — with GitHub Actions Failure
@Elter71 Elter71 had a problem deploying to CI with Mapbox Tokens April 30, 2025 15:15 — with GitHub Actions Failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: On Android, onLongPress function is working only once(initial render)
1 participant