Skip to content

Fix #3780 (iOS): Update lineMetrics type from NSNumber to Bool #3905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 28, 2025
Merged

Fix #3780 (iOS): Update lineMetrics type from NSNumber to Bool #3905

merged 2 commits into from
Jul 28, 2025

Conversation

john-trieu-nguyen
Copy link
Contributor

Description

Fixes #3780

Checklist

  • I've read CONTRIBUTING.md
  • I updated the doc/other generated code with running yarn generate in the root folder
  • I have tested the new feature on /example app.
    • In V11 mode/ios
    • In New Architecture mode/ios
    • In V11 mode/android
    • In New Architecture mode/android
  • I added/updated a sample - if a new feature was implemented (/example)

@john-trieu-nguyen john-trieu-nguyen mentioned this pull request Jul 17, 2025
Closed
@mfazekas
Copy link
Contributor

@john-trieu-nguyen thanks much looks good to me, can you merge to main has fix for CI failure in type-check

@john-trieu-nguyen
Copy link
Contributor Author

@mfazekas done

@john-trieu-nguyen john-trieu-nguyen temporarily deployed to CI with Mapbox Tokens July 28, 2025 12:24 — with GitHub Actions Inactive
@john-trieu-nguyen john-trieu-nguyen temporarily deployed to CI with Mapbox Tokens July 28, 2025 12:24 — with GitHub Actions Inactive
@john-trieu-nguyen john-trieu-nguyen temporarily deployed to CI with Mapbox Tokens July 28, 2025 12:24 — with GitHub Actions Inactive
@john-trieu-nguyen john-trieu-nguyen temporarily deployed to CI with Mapbox Tokens July 28, 2025 12:24 — with GitHub Actions Inactive
@john-trieu-nguyen john-trieu-nguyen temporarily deployed to CI with Mapbox Tokens July 28, 2025 12:24 — with GitHub Actions Inactive
@john-trieu-nguyen john-trieu-nguyen temporarily deployed to CI with Mapbox Tokens July 28, 2025 12:24 — with GitHub Actions Inactive
@john-trieu-nguyen john-trieu-nguyen temporarily deployed to CI with Mapbox Tokens July 28, 2025 12:24 — with GitHub Actions Inactive
@mfazekas mfazekas merged commit c9221c8 into rnmapbox:main Jul 28, 2025
11 checks passed
@john-trieu-nguyen john-trieu-nguyen deleted the fix/line-metrics-type branch July 29, 2025 00:29
efstathiosntonas pushed a commit to efstathiosntonas/maps that referenced this pull request Aug 8, 2025
@john-trieu-nguyen @efstathiosntonas
Update lineMetrics type from NSNumber to Bool (rnmapbox#3905)
17d3b46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Property lineMetrics expected to be a number or nil but was: 1
2 participants
@john-trieu-nguyen @mfazekas