-
-
Notifications
You must be signed in to change notification settings - Fork 35
Add support to set queue options, either globally using queue.php or by implementing an interface #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+96
−44
Merged
Add support to set queue options, either globally using queue.php or by implementing an interface #159
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5e4a445
feat: enhance RoadRunnerQueue and RoadRunnerConnector with options ha…
bohemima c26cf56
feat: implement HasQueueOptions interface and refactor RoadRunnerQueu…
bohemima 3e5149d
update CHANGELOG to include changes
bohemima 6bd9276
fix: change queueOptions method visibility to public in HasQueueOptio…
bohemima 70048d1
feat: handle cases where $job is a string
bohemima b82fdb5
feat: update options handling in RoadRunnerQueue to use default value…
bohemima 9fe8378
fix: update queueOptions method return type to OptionsInterface in Ha…
bohemima File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
<?php | ||
|
||
namespace Spiral\RoadRunnerLaravel\Queue\Contract; | ||
|
||
interface HasQueueOptions | ||
{ | ||
function queueOptions(): array; | ||
} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add explicit visibility modifier and return type declaration
While interface methods are implicitly public in PHP, it's a best practice to explicitly declare the visibility modifier. Additionally, add a return type declaration for better type safety.
Also consider adding PHPDoc to document the expected structure of the returned array:
🤖 Prompt for AI Agents