Improved artifact executable detection #82
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the extractors for both
.zipand.tar/.tar.gzfiles to inspect files within the archives, and runs descriptor (executable contents) detection on them, adding an additional datapoint for hopefully extracting correct binaries from said archives.Notably, this should fix failed extraction for a tool that:
.exe)A real-world scenario where such a thing would happen:
toolauthor/toolnamegets forked asorganization/toolauthor-toolname.zipfiles as its release artifacts (no permission bits)