Skip to content

Conversation

@th3fallen
Copy link
Contributor

@th3fallen th3fallen commented Mar 30, 2022

Get react-select parent using .closest and attribute matchers to match dynamically generated class ex: .css-ab123s-container

Get react-select parent using .closest and attribute matchers to match dynamically generated class
@romgain
Copy link
Owner

romgain commented Mar 31, 2022

Hi @th3fallen !
Thank you very much for your contribution!

it looks like your commit didn’t pass the CI checks: would you mind running npm run prettier:apply to fix this error?

It would also be awesome if you could check the output of npm run test:all-versions to make sure that your change doesn’t break compatibility with older versions of react-select.

Thanks again!

@th3fallen
Copy link
Contributor Author

Ah sorry about that yep I’ll get that fixed up today!

@th3fallen
Copy link
Contributor Author

that should fix it up, while i hate the need for two... stupid emotion spaces

@th3fallen
Copy link
Contributor Author

looks like it fails coverage on my fork, I honestly have no idea how to test that fallback selector, any suggestions?

@romgain
Copy link
Owner

romgain commented Mar 31, 2022

Oh apologies - I don’t think you’ll be able to cover this.

Feel free to add an “Istanbul ignore if” comment to skip this

@th3fallen
Copy link
Contributor Author

done, i hate adding those so just wanted to make sure that was ok by you.

@codecov-commenter
Copy link

Codecov Report

Merging #86 (60c3dd0) into master (1b87123) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #86   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           53        57    +4     
  Branches         9        13    +4     
=========================================
+ Hits            53        57    +4     
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b87123...60c3dd0. Read the comment docs.

@romgain romgain merged commit 3a162ab into romgain:master Apr 1, 2022
@romgain
Copy link
Owner

romgain commented Apr 1, 2022

Thanks again!
v5.4.0 is now available on npm :-)

@romgain
Copy link
Owner

romgain commented Apr 1, 2022

btw, I think that #54 can be fixed using the exact same mechanism - if you feel like it, a PR that fixes it would be greatly appreciated! 😄

@th3fallen
Copy link
Contributor Author

@romgain yeah i'll take a look, but from a precursery glance this change may actually already fix it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants