-
Notifications
You must be signed in to change notification settings - Fork 24
Dynamically get react-select parent #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Get react-select parent using .closest and attribute matchers to match dynamically generated class
|
Hi @th3fallen ! it looks like your commit didn’t pass the CI checks: would you mind running It would also be awesome if you could check the output of Thanks again! |
|
Ah sorry about that yep I’ll get that fixed up today! |
|
that should fix it up, while i hate the need for two... stupid emotion spaces |
|
looks like it fails coverage on my fork, I honestly have no idea how to test that fallback selector, any suggestions? |
|
Oh apologies - I don’t think you’ll be able to cover this. Feel free to add an “Istanbul ignore if” comment to skip this |
|
done, i hate adding those so just wanted to make sure that was ok by you. |
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 53 57 +4
Branches 9 13 +4
=========================================
+ Hits 53 57 +4
Continue to review full report at Codecov.
|
|
Thanks again! |
|
btw, I think that #54 can be fixed using the exact same mechanism - if you feel like it, a PR that fixes it would be greatly appreciated! 😄 |
|
@romgain yeah i'll take a look, but from a precursery glance this change may actually already fix it... |
Get react-select parent using .closest and attribute matchers to match dynamically generated class ex:
.css-ab123s-container