Fix finding R in CMake on Windows if old (side-by-side) version is present #19463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 21 files 21 suites 3d 15h 19m 41s ⏱️ For more details on these failures, see this check. Results for commit 4b6a9e3. ♻️ This comment has been updated with latest results. |
Co-authored-by: Philippe Canal <pcanal@fnal.gov>
Co-authored-by: Philippe Canal <pcanal@fnal.gov>
pcanal
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, if an old installation of R is present (which no longer has the executable tools in it) which is next to a newer one, then skip it and look in the next R subdirectory. Before, the loop would quit after looking in the first folder.