Skip to content

Conversation

magnustymoteus
Copy link
Contributor

@magnustymoteus magnustymoteus commented Jul 28, 2025

This Pull request:

Changes or fixes:

  • Renamed GetColumnsByFieldId to GetAllColumnsOfField
  • Added unit tests for GetAllColumnsOfField because it also recently became a public method

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@magnustymoteus magnustymoteus requested a review from jblomer as a code owner July 28, 2025 11:37
@silverweed silverweed self-assigned this Jul 28, 2025
@silverweed
Copy link
Contributor

Not sure if we actually need the non-recursive GetColumnIds, considering that it's basically just a trivial filter on GetColumnIterable()...do you have a concrete use case for it?

@magnustymoteus
Copy link
Contributor Author

I am currently using it in my treemap visualization, but yes one can easily replace it with a for loop over the GetColumnIterable. I'll remove the method then?

@magnustymoteus magnustymoteus force-pushed the ntupleinspector-getcolumnids branch from 45a5104 to 709119f Compare July 28, 2025 12:15
@magnustymoteus
Copy link
Contributor Author

Alright, I've removed GetColumnIds(fieldId), but not GetColumnIds(colType) because it's used in GetPageSizeDistribution

@magnustymoteus magnustymoteus force-pushed the ntupleinspector-getcolumnids branch 4 times, most recently from 6b4698b to c0296bc Compare July 28, 2025 14:07
Copy link

github-actions bot commented Jul 28, 2025

Test Results

    21 files      21 suites   3d 6h 52m 29s ⏱️
 3 223 tests  3 223 ✅ 0 💤 0 ❌
65 960 runs  65 960 ✅ 0 💤 0 ❌

Results for commit 6cb41c1.

♻️ This comment has been updated with latest results.

@magnustymoteus magnustymoteus changed the title [ntuple] Add GetColumnIds methods in Inspector [ntuple] Change GetColumn methods in Inspector Jul 29, 2025
@magnustymoteus magnustymoteus force-pushed the ntupleinspector-getcolumnids branch from c0296bc to 59a50b0 Compare July 29, 2025 11:18
@magnustymoteus magnustymoteus force-pushed the ntupleinspector-getcolumnids branch from 59a50b0 to 6cb41c1 Compare August 1, 2025 15:36
@silverweed silverweed merged commit 58e1757 into root-project:master Aug 4, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants