Skip to content

Add UHI integration for 8 histogram tutorials and update index.md documentation #19472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 11, 2025
Merged

Add UHI integration for 8 histogram tutorials and update index.md documentation #19472

merged 2 commits into from
Aug 11, 2025

Conversation

senabibi
Copy link
Contributor

@senabibi senabibi commented Jul 29, 2025 •
edited
Loading

This Pull request:

Changes or fixes:

  1. Core Implementation:

    • Integrated UHI into 8 histogram tutorials

  2. Documentation:

    • Added Doxygen documentation for all UHI-integrated tutorials

Checklist:

  • Tested changes locally (all 8 tutorials)
  • Updated documentation (Doxygen + tutorial index)

@senabibi senabibi requested a review from couet as a code owner July 29, 2025 13:01
@martamaja10 martamaja10 changed the title [skip-ci] Add UHI integration for 14 histogram tutorials and update index.md documentation Add UHI integration for 14 histogram tutorials and update index.md documentation Jul 29, 2025
@martamaja10 martamaja10 reopened this Jul 29, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 29, 2025 •
edited
Loading

Test Results

    21 files      21 suites   3d 7h 7m 31s ⏱️
 3 257 tests  3 257 ✅ 0 💤 0 ❌
66 670 runs  66 670 ✅ 0 💤 0 ❌

Results for commit aadd4170.

♻️ This comment has been updated with latest results.

@senabibi senabibi force-pushed the summroot-clean branch 2 times, most recently from f9149de to 1d5ccd6 Compare July 31, 2025 11:24
@senabibi senabibi requested review from pcanal and dpiparo as code owners July 31, 2025 11:24
siliataider
siliataider requested changes Jul 31, 2025
View reviewed changes
@siliataider siliataider removed the request for review from pcanal July 31, 2025 14:31
@siliataider
Copy link
Contributor

siliataider commented Jul 31, 2025 •
edited
Loading

Thank you @senabibi for your first contribution! These additions will be nice to have in the documentation.
I left a first round of cleanup comments, can you please take a look?
You also mention adding 14 tutorials, but I only see 8 new files, did you maybe forget to add files?

@senabibi senabibi closed this Jul 31, 2025
@senabibi senabibi reopened this Jul 31, 2025
@senabibi senabibi requested a review from bellenot as a code owner August 1, 2025 12:54
@senabibi senabibi requested a review from siliataider August 4, 2025 10:35
@senabibi senabibi changed the title Add UHI integration for 14 histogram tutorials and update index.md documentation Add UHI integration for 8 histogram tutorials and update index.md documentation Aug 4, 2025
@senabibi
Copy link
Contributor Author

senabibi commented Aug 4, 2025

You also mention adding 14 tutorials, but I only see 13 new files, did you maybe forget to add a file?

My bad, I just updated the proper number!

siliataider
siliataider requested changes Aug 4, 2025
View reviewed changes
Copy link
Contributor

@siliataider siliataider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some small final cleanup needed

@senabibi senabibi force-pushed the summroot-clean branch 2 times, most recently from 942a84b to 3c7155b Compare August 5, 2025 07:25
siliataider
siliataider approved these changes Aug 5, 2025
View reviewed changes
Copy link
Contributor

@siliataider siliataider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

martamaja10
martamaja10 requested changes Aug 5, 2025
View reviewed changes
Copy link
Contributor

@martamaja10 martamaja10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Nursena for these nice additions. Having a deeper look now, I think we should not include tutorial hist105 here (not the problem of your changes but generally I think this tutorial in its Python version is not fully functional at the moment so it needs some investigation). So I would remove it from the PR and modify the index.md file accordingly.

@siliataider siliataider mentioned this pull request Aug 5, 2025
Merged
@senabibi senabibi force-pushed the summroot-clean branch 2 times, most recently from 32c08da to 132a718 Compare August 6, 2025 09:42
martamaja10
martamaja10 approved these changes Aug 11, 2025
View reviewed changes
Copy link
Contributor

@martamaja10 martamaja10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this nice PR Nursena!

@siliataider siliataider merged commit d11aef6 into root-project:master Aug 11, 2025
26 checks passed
guitargeek added a commit to guitargeek/root that referenced this pull request Aug 12, 2025
@guitargeek
[tutorials] Fix vetos for UHI tutorials
32bb2f8 
Following up on root-project#19472. One can't do `file(GLOB ..)` with two separate
output variables. Also, don't claim that the tutorial
`hist002_TH1_fillrandom_userfunc_uhi.py` requires mplhep and matplotlib,
because it only requires NumPy.
@guitargeek guitargeek mentioned this pull request Aug 12, 2025
Merged
guitargeek added a commit to guitargeek/root that referenced this pull request Aug 13, 2025
@guitargeek
[tutorials] Fix vetos for UHI tutorials
ed612b8 
Following up on root-project#19472. One can't do `file(GLOB ..)` with two separate
output variables. Also, don't claim that the tutorial
`hist002_TH1_fillrandom_userfunc_uhi.py` requires mplhep and matplotlib,
because it only requires NumPy.
guitargeek added a commit that referenced this pull request Aug 13, 2025
@guitargeek
[tutorials] Fix vetos for UHI tutorials
232b846 
Following up on #19472. One can't do `file(GLOB ..)` with two separate
output variables. Also, don't claim that the tutorial
`hist002_TH1_fillrandom_userfunc_uhi.py` requires mplhep and matplotlib,
because it only requires NumPy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siliataider siliataider siliataider approved these changes

@martamaja10 martamaja10 martamaja10 approved these changes

@couet couet Awaiting requested review from couet couet is a code owner

@dpiparo dpiparo Awaiting requested review from dpiparo

@bellenot bellenot Awaiting requested review from bellenot bellenot is a code owner

Assignees

@senabibi senabibi

Labels
in:Tutorials
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@senabibi @siliataider @martamaja10