-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Option Title: with title containing tex #19474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results 21 files 21 suites 3d 7h 29m 8s ⏱️ Results for commit 560c046. ♻️ This comment has been updated with latest results. |
could this be backported and merged to 6.36 when merged? |
Thanks for this nice fix Olivier!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but can you add a Unit Test, as suggested by @ferdymercury?
Note the proper syntax is:
With parenthesis... not square brakets. |
Both options are supported, see e06e246 |
This is not equivalent. Try your test with [ and see the doc of TPad::Print |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
With pdf output it is possible to define a table of content of a multi-pages file. Each page has its name specified using the option "Title:" followed by the title of the page. If the title contains a string matching a possible file extension like, for instance, "tex" or "png", then the pdf generation went wrong and might crash. This PR fixes the problem.
Fixes #19390