-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[roottest] use cmake for root/tree tests #19492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1706efd
to
6a9a2a1
Compare
Test Results 21 files 21 suites 3d 11h 2m 15s ⏱️ Results for commit fb7cad4. ♻️ This comment has been updated with latest results. |
6a9a2a1
to
fd8729e
Compare
Delete unused tree.h and tree.C macros, were copied from root/io/treeproblem
Extra rule to copy rootlogin.C script Remove unused mixing.ref file
Was not used in Makefile
Reactivate runabstract.cxx test
Need extra work to use selectors and files from source directory
Avoid extra configuring of include path
Two tests failing while eventdata.root file is missing on eos
Getting linker failure when trying to compile hardTreeReaderTest.cpp macro. ``` hardTreeReaderTest_cpp_ACLiC_dict.obj : error LNK2019: unresolved external symbol "public: static class TClass * __cdecl B::Class(void)" (?Class@B@@SAPEAVTClass@@xz) referenced in function "public: class TBranch * __cdecl TTree::Branch<class B>(char const *,class B * *,int,int)" (??$Branch@VB@@@ttree@@QEAAPEAVTBranch@@PEBDPEAPEAVB@@hh@Z) [C:\ROOT-CI\build\roottest\root\tree\reader\roottest-root-tree-reader-hardTreeReaderTest-compile-macro.vcxproj] hardTreeReaderTest_cpp_ACLiC_dict.obj : error LNK2001: unresolved external symbol "public: virtual void __cdecl B::Streamer(class TBuffer &)" (?Streamer@B@@UEAAXAEAVTBuffer@@@z) [C:\ROOT-CI\build\roottest\root\tree\reader\roottest-root-tree-reader-hardTreeReaderTest-compile-macro.vcxproj] hardTreeReaderTest_cpp_ACLiC_dict.obj : error LNK2019: unresolved external symbol "public: static class TClass * __cdecl A::Class(void)" (?Class@A@@SAPEAVTClass@@xz) referenced in function "public: virtual class TClass * __cdecl A::IsA(void)const " (?IsA@A@@UEBAPEAVTClass@@xz) [C:\ROOT-CI\build\roottest\root\tree\reader\roottest-root-tree-reader-hardTreeReaderTest-compile-macro.vcxproj] hardTreeReaderTest_cpp_ACLiC_dict.obj : error LNK2001: unresolved external symbol "public: virtual void __cdecl A::Streamer(class TBuffer &)" (?Streamer@A@@UEAAXAEAVTBuffer@@@z) [C:\ROOT-CI\build\roottest\root\tree\reader\roottest-root-tree-reader-hardTreeReaderTest-compile-macro.vcxproj] C:\ROOT-CI\build\roottest\root\tree\reader\hardTreeReaderTest_cpp.dll : fatal error LNK1120: 4 unresolved externals [C:\ROOT-CI\build\roottest\root\tree\reader\roottest-root-tree-reader-hardTreeReaderTest-compile-macro.vcxproj] ```
fd8729e
to
fb7cad4
Compare
Closing in favor of #19516, which includes all necessary changes in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.