Skip to content

[roottest] use cmake for root/tree tests #19492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from

Conversation

linev
Copy link
Member

@linev linev commented Jul 31, 2025

No description provided.

@linev linev requested a review from pcanal July 31, 2025 16:37
@linev linev self-assigned this Jul 31, 2025
@linev linev requested a review from bellenot as a code owner July 31, 2025 16:37
@linev linev requested a review from dpiparo as a code owner July 31, 2025 16:37
@linev linev force-pushed the roottest_tree_part1 branch from 1706efd to 6a9a2a1 Compare July 31, 2025 17:13
Copy link

github-actions bot commented Jul 31, 2025

Test Results

    21 files      21 suites   3d 11h 2m 15s ⏱️
 3 268 tests  3 268 ✅ 0 💤 0 ❌
66 899 runs  66 899 ✅ 0 💤 0 ❌

Results for commit fb7cad4.

♻️ This comment has been updated with latest results.

@linev linev force-pushed the roottest_tree_part1 branch from 6a9a2a1 to fd8729e Compare August 1, 2025 07:14
linev added 12 commits August 1, 2025 10:02
Delete unused tree.h and tree.C macros,
were copied from root/io/treeproblem
Extra rule to copy rootlogin.C script
Remove unused mixing.ref file
Reactivate runabstract.cxx test
Need extra work to use selectors and files from source directory
Two tests failing while eventdata.root file is missing on eos
Getting linker failure when trying to compile hardTreeReaderTest.cpp macro.

```
hardTreeReaderTest_cpp_ACLiC_dict.obj : error LNK2019: unresolved external symbol "public: static class TClass * __cdecl B::Class(void)" (?Class@B@@SAPEAVTClass@@xz) referenced in function "public: class TBranch * __cdecl TTree::Branch<class B>(char const *,class B * *,int,int)" (??$Branch@VB@@@ttree@@QEAAPEAVTBranch@@PEBDPEAPEAVB@@hh@Z) [C:\ROOT-CI\build\roottest\root\tree\reader\roottest-root-tree-reader-hardTreeReaderTest-compile-macro.vcxproj]
  hardTreeReaderTest_cpp_ACLiC_dict.obj : error LNK2001: unresolved external symbol "public: virtual void __cdecl B::Streamer(class TBuffer &)" (?Streamer@B@@UEAAXAEAVTBuffer@@@z) [C:\ROOT-CI\build\roottest\root\tree\reader\roottest-root-tree-reader-hardTreeReaderTest-compile-macro.vcxproj]
  hardTreeReaderTest_cpp_ACLiC_dict.obj : error LNK2019: unresolved external symbol "public: static class TClass * __cdecl A::Class(void)" (?Class@A@@SAPEAVTClass@@xz) referenced in function "public: virtual class TClass * __cdecl A::IsA(void)const " (?IsA@A@@UEBAPEAVTClass@@xz) [C:\ROOT-CI\build\roottest\root\tree\reader\roottest-root-tree-reader-hardTreeReaderTest-compile-macro.vcxproj]
  hardTreeReaderTest_cpp_ACLiC_dict.obj : error LNK2001: unresolved external symbol "public: virtual void __cdecl A::Streamer(class TBuffer &)" (?Streamer@A@@UEAAXAEAVTBuffer@@@z) [C:\ROOT-CI\build\roottest\root\tree\reader\roottest-root-tree-reader-hardTreeReaderTest-compile-macro.vcxproj]
  C:\ROOT-CI\build\roottest\root\tree\reader\hardTreeReaderTest_cpp.dll : fatal error LNK1120: 4 unresolved externals [C:\ROOT-CI\build\roottest\root\tree\reader\roottest-root-tree-reader-hardTreeReaderTest-compile-macro.vcxproj]
  ```
@linev linev force-pushed the roottest_tree_part1 branch from fd8729e to fb7cad4 Compare August 1, 2025 08:28
@linev
Copy link
Member Author

linev commented Aug 4, 2025

Closing in favor of #19516, which includes all necessary changes in root/tree tests

@linev linev closed this Aug 4, 2025
@linev linev deleted the roottest_tree_part1 branch August 5, 2025 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant