Skip to content

[hadd] do not print info to stderr #19503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ferdymercury
Copy link
Collaborator

This Pull request:

Changes or fixes:

Fixes #19479

@ferdymercury ferdymercury requested a review from pcanal as a code owner August 1, 2025 15:21
@ferdymercury ferdymercury requested a review from silverweed August 1, 2025 16:35
Copy link

github-actions bot commented Aug 1, 2025

Test Results

    21 files      21 suites   3d 10h 14m 3s ⏱️
 3 223 tests  3 223 ✅ 0 💤 0 ❌
65 909 runs  65 909 ✅ 0 💤 0 ❌

Results for commit c9d3d62.

@silverweed
Copy link
Contributor

I don't think we should print the Info() messages on stdout; I'd rather have an option to silence the output altogether if that's the desired outcome (we already have a verbosity option: we can simply not emit Info() if verbosity is less than 1 or something)

@ferdymercury ferdymercury marked this pull request as draft August 4, 2025 08:34
Copy link
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently this PR is awaiting additional feedback in the issue (it is not clear what the underlying issue really is).

@ferdymercury
Copy link
Collaborator Author

ferdymercury commented Aug 4, 2025

There was a change of behavior, in ROOT 6.32 hadd printed info messages to std::cout
In ROOT 6.36 they are printed to std::cerr, so I guess the user is surprised or confused by this change.
Maybe the easiest is to document this change in the release notes and close isssue as won't fix.

@pcanal
Copy link
Member

pcanal commented Aug 4, 2025

close isssue as won't fix.

Before doing that, I would like to hear from the user what explicitly bother them and how, so we can clarify the situation from their point of view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Info() logs should not go to stderr
3 participants