Skip to content

Doc updateQueryString: / cleans URL with no query #3885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Doc updateQueryString: / cleans URL with no query #3885

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca37409
Doc updateQueryString: / cleans URL with no query
Mkranj Aug 31, 2023
3fe4ce3
Merge branch 'main' into doc_update_query
Mkranj Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion R/bookmark-state.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,7 +550,8 @@ restoreInput <- function(id, default) {
#' When `mode = "push"`, the function called is
#' `window.history.pushState(null, null, queryString)`.
#'
#' @param queryString The new query string to show in the location bar.
#' @param queryString The new query string to show in the location bar. "?" for
#' empty query arguments, "/" to reset to a clean URL.
#' @param mode When the query string is updated, should the the current history
#' entry be replaced (default), or should a new history entry be pushed onto
#' the history stack? The former should only be used in a live bookmarking
Expand Down