Skip to content

Fix webhook auth: use HMACSHA256 #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Fix webhook auth: use HMACSHA256 #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions rubberduckvba.Server/WebhookSignatureValidationService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,13 @@ private bool IsValidSignature(string? signature, string payload)
{
return false;
}
using var sha256 = SHA256.Create();

var secret = configuration.GitHubOptions.Value.WebhookToken;
var bytes = Encoding.UTF8.GetBytes(secret + payload);
var check = $"sha256={Encoding.UTF8.GetString(sha256.ComputeHash(bytes))}";
var secretBytes = Encoding.UTF8.GetBytes(secret);
var payloadbytes = Encoding.UTF8.GetBytes(payload);

using var digest = new HMACSHA256(secretBytes);
var check = $"sha256={Encoding.UTF8.GetString(digest.ComputeHash(payloadbytes))}";

return signature == check;
}
Expand Down