implemented optional logger to log details when applying migrations #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rubenv Do you already have an info regarding this PR? |
|
@rubenv Any thoughts on this? We periodically leverage migrations which may run long, and having this log data would really be a quality-of-life improvement when those are applying. |
|
@eldondevat As I did not get a response for a long time, I built a workaround for this topic, by:
You can find the implementation in: https://github.com/allaboutapps/go-starter/blob/master/cmd/db/migrate.go#L74 Of course it would be nice, to have some kind of support built into sql-migrate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, here is a PR for the enhanced logging infos when applying migrations, proposed in #266