Check if the image built is working before pushing #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelfranca
force-pushed
the
rmf-check-images-before-build
branch
from
01deda6 to
223f777
Compare
rafaelfranca
force-pushed
the
rmf-check-images-before-build
branch
from
223f777 to
fc6b46c
Compare
Contributor
|
The approach in #146 is simpler and I think, good enough, given that the build action will alert any |
Author
|
Both will, but I'm happy with that as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few times in the past the ruby image build in this project wasn't a valid Ruby.
To avoid that problem we should fail and report instead of pushing to the repository.